Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifies movies as series #61

Closed
kolbdog323 opened this issue Apr 3, 2024 · 15 comments
Closed

Identifies movies as series #61

kolbdog323 opened this issue Apr 3, 2024 · 15 comments

Comments

@kolbdog323
Copy link

Just letting you kow there is an issue with media hoarder indetifing certain movies as series. FOr example i just tried adding the addams family series from 1964 without the year and it identified it as a movie same with the Pippi longstocking 1997 tv series it identified that as the Pippi Longstocking movie from 1997. I think you need to fix it so it only identifies series not movies with same name.

@theMK2k
Copy link
Owner

theMK2k commented Apr 3, 2024

Hi @kolbdog323,

thanks for your feedback. Yes, the IMDB detection needs optimization here. I will let you know as soon as an updated version is available.

@kolbdog323
Copy link
Author

Just suggestion maybe it will look for a page that has the words tv series in the actual page because all the tv series say tv series on the main sereis page maybe that might help for the issue of it accidentally identifying a movie as a series if you dont put the (start year to end year) in file name? Since if you go onto a tv series page it says TV Series then it shows the start year - end year after that?

@theMK2k
Copy link
Owner

theMK2k commented Apr 18, 2024

Yes, IMDB provides certain types, like 'tv-series', 'tv-episode' or 'feature' in their data. We will leverage that.

@theMK2k
Copy link
Owner

theMK2k commented Jun 28, 2024

In the upcoming v1.4.0-b6 we'll have an optimized IMDB entry detection where as soon as a Series source path is scanned, the IMDB search results are re-ranked by the media type ("TV Series" before "Movie").

I tested the optimized IMDB detection with both of your examples, here is the directory/file structure:

Series\The Addams Family
    Season01
        The Addams Family S01E01.mkv
        The Addams Family S01E02.mkv

Series\Pippi Longstocking (1997-1998)
    Season01
        Pippi Longstocking S01E01.mkv
        Pippi Longstocking S01E02.mkv

The results after scanning are as expected now:

image

theMK2k added a commit that referenced this issue Jun 28, 2024
…-series are higher than movies when detecting the IMDB entry

  - closes #61

increase version to v1.4.0-b6
@theMK2k
Copy link
Owner

theMK2k commented Jun 28, 2024

v1.4.0-b6 is released. If you run v1.4.0-b5 it should also tell you about the update - please let me know if that worked for you also ;)

@kolbdog323
Copy link
Author

How does that work anyways series ranked higher than movies? Just wondering before I test it out?

@theMK2k
Copy link
Owner

theMK2k commented Jun 28, 2024

During the scan, Media Hoarder "sees" the new series and its directory is "Pippi Longstocking (1997-1998)".

As the directory does not contain the tt*, Media Hoarder performs a search on IMDB (like you would do by using the imdb.com site's search).

With the search, Media Hoarder gets a result (44 results for the search term "Pippi Longstocking".

Amongst the 44 results, we get the year (e.g. 1997 for both the movie and the series) as well as the information if it's a TV Series.

Now, with the optimization, the results get re-ranked by putting all TV Series entries to the top.

With the re-ranked results, Media Hoader now takes the first element in the list that additionally matches the year (1997). And this is now the Pippi Longstocking tv series instead of the movie.

@theMK2k
Copy link
Owner

theMK2k commented Jun 28, 2024

The gist is: the search result on IMDB for "Pippi Longstocking" brings up the movie before the tv series. With the re-ranking we move the tv series entry up so that it will be chosen by Media Hoarder.

@kolbdog323
Copy link
Author

Ah. Okay thanks wasn't sure how that worked.

@kolbdog323
Copy link
Author

Will that work for movies that have same name and release year as a tv show since some movies have same name and release year as a show but not always .

@theMK2k
Copy link
Owner

theMK2k commented Jun 28, 2024

I would need to test that, too

@theMK2k
Copy link
Owner

theMK2k commented Jun 28, 2024

or do you have a good example where the tv series comes higher up in the search result on imdb than the movie?

@theMK2k
Copy link
Owner

theMK2k commented Jun 28, 2024

that would then be a good candidate to test

@kolbdog323
Copy link
Author

Not at moment just wonering.

@theMK2k
Copy link
Owner

theMK2k commented Jun 28, 2024

No need to wonder anymore, I just enhanced the logging a bit and it works like this for Movies source path:

The search results will be completely stripped off TV Series and TV Episodes when the scanning is done on a Movies source path.

@theMK2k theMK2k closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants