Move @types/react to devDependencies to prevent version conflicts in … #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transitive dependencies. Upgrade ts-react-toolbox so dist builds pass.
gregolai
commented
Apr 13, 2020
| @@ -2,13 +2,153 @@ | |||
| # yarn lockfile v1 | |||
|
|
|||
|
|
|||
| "@babel/code-frame@^7.0.0", "@babel/code-frame@^7.0.0-beta.35": | |||
There was a problem hiding this comment.
Most of the diffs here occurred from just running npx yarn
|
@theKashey Could I get some 👀 on this at your convenience? Thanks! |
|
Sorry, missed this PR as well as the issue. |
|
The package has been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
Having
@types/reactin dependencies was causing version-conflict issues with anything that hasuse-callback-refas a dependency, such asreact-focus-lock(great library, by the way).@types/reactshould go in devDependencies.ts-react-toolboxwas also behind, which was causing dist builds to have type errors, so I upgraded it to the latest version and the errors went away.