Add explicit crossFrame support for ReactFocusLock
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theKashey I opened this PR to hopefully save you a bit of time - please let me know if you see any issues, or if you have objections to support being added! |
|
Hey @cee-chen - thank you for stepping in and, well, making the change happen. Even if this is just a few lines my time is quite limited nowadays. Change is approved, but can you help me create a better explanation for this prop. It's not about behavior of iframes, but behavior if "you" are inside iframe. Something like (generated by ChatGPT 🤷♂️) |
theKashey
approved these changes
Jun 27, 2023
|
No problem at all, super happy to help! Let me tweak the docs copy here a bit based on your prompt! |
cee-chen
commented
Jun 28, 2023
|
@theKashey let me know if that resolves your docs request or if you think the |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #72
As of 2.3.0,
react-focus-lockhas supported acrossFrameprop which allows focus to escape to outside iframes whenfalse.react-focus-oncurrently does not expose passing that prop directly toreact-focus-lock, but we'd really appreciate that support being added 🙏Please let me know if I'm missing any docs or tests in this PR!