-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #285, migrate to TypeScript #334
base: master
Are you sure you want to change the base?
Conversation
Thanks, this definitely can save me heaps of time |
This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far. |
This is still relevant. |
Please dont worry about conflicts. |
This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far. |
This PR migrates the code to TypeScript.
I kept Babel for compilation to keep it small.
There were a couple of type mismatches that I believe are bugs:
moveFocusInside
returns void?useMergeRefs
.Type declarations coming from
focus-lock
need fixing too (focusSolver
can accept arrays):Anyway, in the current state it requires some minor polishing but I leave it to you to verify.
Hopefully it saves you some work and could speed up introducing TS.