Replace defaultProps with default function parameters #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As default props on function components are going to be deprecated in future release in favor of default function parameters (see: facebook/react#16210), I followed the recommendation. Note that default function parameters were actually already used (see `lockProps` for example)!
theKashey
approved these changes
Oct 12, 2023
theKashey
reviewed
Oct 12, 2023
| @@ -34,7 +34,7 @@ const FocusLock = React.forwardRef(function FocusLockUI(props, parentRef) { | |||
| lockProps: containerProps = {}, | |||
| sideCar: SideCar, | |||
|
|
|||
| returnFocus: shouldReturnFocus, | |||
| returnFocus: shouldReturnFocus = false, | |||
There was a problem hiding this comment.
😲 oh, it's disabled by default?! 🫠
Well, for these poor souls stuck on JavaScript for whatever reason, propTypes may actually come in handy. I personally keep it in all my TypeScript repositories anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As default props on function components are going to be deprecated in future release in favor of default function parameters (see: facebook/react#16210), I followed the recommendation. Note that default function parameters were actually already used (see
lockPropsfor example)!