Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct crossframe behavior for Safari, fixes #249 #250

Merged
merged 1 commit into from
Jul 9, 2023
Merged

fix: correct crossframe behavior for Safari, fixes #249 #250

merged 1 commit into from
Jul 9, 2023

Conversation

theKashey
Copy link
Owner

@theKashey theKashey commented Jul 9, 2023 •
edited
Loading

Two actions are not in sync. As a solution:

  • remove setImmediate, it does not really exists in browsers, but makes tests happy
  • use the same defer helper for both cases.

@theKashey theKashey merged commit c37eec1 into master Jul 9, 2023
@theKashey
Copy link
Owner Author

💩 this change is lacking automated test 💩

nickspaargaren pushed a commit to nickspaargaren/react-focus-lock that referenced this pull request Dec 11, 2024
@theKashey
Merge pull request theKashey#250 from theKashey/correct-cross-frame
91891b3 
fix: correct crossframe behavior for Safari, fixes theKashey#249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theKashey