Update focus-lock version #186
Conversation
| @@ -10,5 +10,5 @@ jobs: | |||
| - checkout | |||
| - run: yarn | |||
| - run: yarn lint | |||
| - run: yarn size | |||
| - run: NODE_OPTIONS=--openssl-legacy-provider yarn size | |||
There was a problem hiding this comment.
Added this to fix the following issue.
More Details here - webpack/webpack#14532
There was a problem hiding this comment.
Thanks. I was close to switch to old good Travis.
| @@ -14,7 +14,7 @@ | |||
| "build:es5": "NODE_ENV=es2015 babel src -d dist/es2015", | |||
| "build": "rm -Rf ./dist && yarn build:es5 && yarn build:cjs", | |||
| "test": "npm run test:pick -- '_tests/**/*spec.js'", | |||
| "test:pick": "NODE_ENV=cjs mocha --require @babel/register --require jsdom-global/register --require _tests/spinup/scaffolding ", | |||
| "test:pick": "NODE_ENV=cjs mocha --require @babel/register --require jsdom-global/register --require _tests/spinup/scaffolding --exit", | |||
There was a problem hiding this comment.
this fixes the following issue with yarn test just being stuck and timing out after completing the tests.
There was a problem hiding this comment.
OH, I was suffering from this for quite a while and was going to replace mocha by (a more common for me) jest next week.
Thank you!
|
🤝 |
|
Thanks, what do we do about |
|
Please ping me here once a new version is released with this change. Thanks |
|
2.7.1 has been just released. |
|
Yay! party! |
|
also, confirmed the prevent scroll is working with this release. Thanks |
…focus Update focus-lock version
Fixes #162
@theKashey We would also need to bump the focus-lock version to fix the above issue.