Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught TypeError: Cannot read properties of undefined (reading 'tagName') if no innerTabbable elements present #63

Closed
veksa opened this issue Feb 16, 2024 · 2 comments
Closed

Uncaught TypeError: Cannot read properties of undefined (reading 'tagName') if no innerTabbable elements present #63

veksa opened this issue Feb 16, 2024 · 2 comments
Assignees
@theKashey

Comments

@veksa
Copy link

veksa commented Feb 16, 2024

Error in focusSolver function if there are no any orderedInnerElements with tabIndex >= 0

image
@theKashey theKashey self-assigned this Feb 16, 2024
@theKashey
Copy link
Owner

This probably explains #53

Behaviour has changed at 1.0.1 as a part of focus restoration correction, where non-tabbale elements were not considered as possible options.
Use case with no tabble elements was missed, sorry

theKashey added a commit that referenced this issue Feb 16, 2024
@theKashey
Merge pull request #64 from theKashey/no-tabbable-case
249e81a 
fix: support lock reactivation with no tabble nodes, fixes #63
@theKashey
Copy link
Owner

Fix released in 1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theKashey theKashey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theKashey @veksa