Remove EditForm and Regular Expressions to cut dependencies. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor URL validation and form handling in LinkBundle and NewLink Refactored the validation process for the `VanityUrl` property in the `LinkBundle` class to check for letters, numbers, and dashes without using regex. The `NewLink.razor` file was significantly refactored, replacing the `EditForm` component with a standard HTML form and the `OnValidSubmit` method with an `OnSubmit` method that includes a URL validation check. The `Link` and `LinkBundle` classes no longer use data annotations or regular expressions for URL validation. Minor refactoring was also done on the `GetOpenGraphInfoForLink` method in `NewLink.razor`, mainly for code formatting and indentation.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-forest-0ccd7d90f-55.eastus2.3.azurestaticapps.net |
Update PR with SVG banner
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-forest-0ccd7d90f-55.eastus2.3.azurestaticapps.net |
Update from main
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-forest-0ccd7d90f-55.eastus2.3.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://victorious-forest-0ccd7d90f-55.eastus2.3.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor URL validation and form handling in LinkBundle and NewLink
Refactored the validation process for the
VanityUrlproperty in theLinkBundleclass to check for letters, numbers, and dashes without using regex. TheNewLink.razorfile was significantly refactored, replacing theEditFormcomponent with a standard HTML form and theOnValidSubmitmethod with anOnSubmitmethod that includes a URL validation check. TheLinkandLinkBundleclasses no longer use data annotations or regular expressions for URL validation. Minor refactoring was also done on theGetOpenGraphInfoForLinkmethod inNewLink.razor, mainly for code formatting and indentation.Reference on removing EditForm: dotnet/runtime#38439