RFC 9229: Babel v4-via-v6#986
Open
jech wants to merge 3 commits into
Open
Conversation
Contributor
Author
mcr
approved these changes
Jan 7, 2023
Member
mcr
left a comment
mcr
left a comment
There was a problem hiding this comment.
Seems fine to me, thank for the additional test case.
Do you have coverage of all the code paths?
Contributor
Author
|
No, the provided trace only contains Update TLVs with the new encoding. The new encoding is also allowed in Request TLVs, but they are NOT RECOMMENDED by the RFC, and are not generted by any implementation in existence: I'd need to specifically craft a packet with them. |
Contributor
Author
|
Ping? |
mcr
approved these changes
Mar 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for displaying routes announced according to RFC 9229 .