UBI: Wire-up fastmap in kernel instead of boot#1
Merged
Biktorgj merged 3 commits intothe-modem-distro:linux-3.18.140from Aug 4, 2021
Merged
UBI: Wire-up fastmap in kernel instead of boot#1Biktorgj merged 3 commits intothe-modem-distro:linux-3.18.140from
Biktorgj merged 3 commits intothe-modem-distro:linux-3.18.140from
Conversation
Normally when fastmap is enabled in kernel configuration it is compiled into the kernel, but disabled by default. Only when setting kernel boot parameter fm_autoconvert at boot to "1" it will convert all non fastmap images to use fastmap. To prevent cluttering up the kernel boot parameters, I've hardcoded the fm_autoconvert, and the fm_debug (only debugging) into the kernel build. Now you can set it at build time in kernel configuration.
Contributor
Author
|
This helps with the slow attaching of the ubiattach. |
Compilation complains about fm_sem not being defined. This error is valid, because in our sourcedrop it is called fm_eba_sem. Probably Quectel changed some code to the ubi driver, because mainline defines it as fm_sem as well. But because fm_eba_sem has been used already in many places in the code just change these over to fm_eba_sem as well. Is the easiest fix.
Another code clean-up to the UBI code. In all code pnum is just used as plain "int pnum" For some reason in the check_mapping function it is defined as int *pnum, which it complains about as invalid operand. Change all instances op *pnum to plain pnum, inline with the rest of the code.
PsychoGame
force-pushed
the
fastmap-patches
branch
from
c4b3288 to
e82fd59
Compare
Collaborator
|
I just reread your comment to remember this pull request... was just doing this... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally when fastmap is enabled in kernel configuration
it is compiled into the kernel, but disabled by default.
Only when setting kernel boot parameter fm_autoconvert
at boot to "1" it will convert all non fastmap images
to use fastmap.
To prevent cluttering up the kernel boot parameters, I've
hardcoded the fm_autoconvert, and the fm_debug (only debugging)
into the kernel build. Now you can set it at build time in
kernel configuration.