fix installation step for lsp_dap
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@the-mikedavis could you help me with issue that you have mentioned (about nopr-flake-dap-fixes branch) Is it actual? |
|
should I drop section about ErlangLS ? It is not necessary to have ErlangLS for this tutorial |
Yeah let's drop that section, installing the language server shouldn't be necessary |
|
I think I upstreamed all the fixes on that branch, so it should no longer be necessary to build erlang_ls from that branch or use a special helix build: erlang-ls/erlang_ls#1347, erlang-ls/erlang_ls#1345, erlang-ls/erlang_ls#1346 / helix-editor/helix#2959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since erlang-ls/erlang_ls#1447 els_dap is in separate repo