-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modern UI / Nextcloud Theme #629
Conversation
Great work hampoelz! This way there's my simple CSS and your terrific advanced one. |
Sorry, it seems i accidentally released your WIP in the Nextcloud release while i was testing your work. I've removed it so that next release won't have it. |
Ah, no problem. Let's just say it's a short public test. ;) But you might want to take a look at Nextcloud app release automations to prevent such things. |
Great work @hampoelz this new theme looks amazing. Wondering what is pending for it be released @the-djmaze |
@hampoelz How can we install this theme for a test? |
@elhananjair You need to perform the following steps to install the theme: First download the files Then create a folder named "NextcloudV25+" inside Finally, copy the previously downloaded files to Since the theme isn't officially included yet, you need to reinstall it after each SnappyMail update. Note: Depending on your Nextcloud installation, SnappyMail may be installed in the |
@elhananjair Thank you very much for your report.
|
Hello @hampoelz
|
Hey @elhananjair, The checkbox next to the search bar is for selecting all mails at once and is provided by SnappyMail, not by the theme. I don't want to change the contrast much as it wouldn't match the rest of the Nextcloud theming. Also, I don't think it's a good idea to separate the search more from the list. However, after some fiddling around, I came up with the following style, which would at least contrast the top tools slightly: |
Hello @hampoelz I liked the style you applied to the top tools, which, I think is enough for slight contrast between the top tools and other components. |
@the-djmaze the work of @hampoelz looks very good, would you add something or could this PR be merged? 🙂 |
Yup I think its ready for the merge as well |
I hope this theme will be the default theme for Snappymail. |
Thanks again @hampoelz for your great work 🙂🥳 |
Is it possible to use this without the Nextcloud app? I run snappymail on a separate domain but it can also be accessed via an iframe on nextcloud. For now I created a custom theme by copying your styles.css (great work btw), but it would be great if it was available as a "normal" theme. |
The theme is not dependent on Nextcloud. So it would be theoretically possible. It even contains styles for some elements that are not shown in the Nextcloud version of SnappyMail, like the login screen. |
Then i will move it from https://github.com/the-djmaze/snappymail/tree/master/integrations/nextcloud/snappymail/app/themes/NextcloudV25%2B to https://github.com/the-djmaze/snappymail/tree/master/snappymail/v/0.0.0/themes |
I will take this into consideration @jdaviescoates. But this may take a few weeks as I want to wait for feedback / issues before creating a PR with fixes and improvements for the theme. |
Introduction
In order to improve the experience with snappymail - especially with the snappymail app for nextcloud - I decided to create a new snappymail theme that follows the style of nextcloud and offers an integration with the nextcloud theme app to provide a seamless experience.
Already mentioned in: #96 and #569
Compromises
SnappyMail's default CSS variables for styling
I didn't use SnappyMail's variables for two reasons:
So it was cleaner for me not to use the snappymail variables.
Suggestions/Discussion
placeholder for blocked images
Currently there are some issues with blocking images/tracking in mail - it leads to wrong layouts or even distorted images - and it just doesn't look good in the end.
My suggestion would be instead of displaying broken/not loaded images, display styleable placeholders with a width and height - like many other webmail pages (Roundcube, Protonmail, ...) do.
standalone SnappyMail theme
It would also be possible to add this theme to the "standalone" Snappymail version - color changes of the theme are possible through the
variables.css
-file I added. When the theme is done, it should be possible to change every single color using this file/css variables - unlike SnappyMail's current CSS variables.(Disadvantage: These variables are then applied globally to the entire theme and are not as modular as those of snappymail, where each area (login, settings, ...) can be color-adjusted individually.)
Nextcloud backwards compatibility
I only tested the theme on Nextcloud 25, as this is the upstream version. Theoretically, the theme could also be provided for older versions.
Checklist
To give an insight into the current status of the theme, here is a checklist:
Conclusion
The theme isn't quite finished yet, but it's already usable. This pull request is used to provide some information about the status of the theme and to track the progress.
To have a larger discussion on any of the above topics, consider creating a separate issue as it is beyond the scope of this PR.