Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links with @ in them are getting truncated #955

Closed
Zero3K opened this issue Feb 14, 2023 · 6 comments
Closed

Links with @ in them are getting truncated #955

Zero3K opened this issue Feb 14, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@Zero3K
Copy link

Zero3K commented Feb 14, 2023

All links with @ in them are getting truncated. I am attaching screenshots of the email that is showing the issue under SnappyMail but not under mboxview and am also attaching the email.

Motherless - SnappyMail
Motherless - mboxview
A friend request from Violetath6.eml.txt

@the-djmaze
Copy link
Owner

@ is not a valid URI character. Should be %40

@the-djmaze the-djmaze closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2023
@the-djmaze the-djmaze added the wontfix This will not be worked on label Feb 14, 2023
@Zero3K
Copy link
Author

Zero3K commented Feb 14, 2023

What about adding code that detects if it is part of a text string that starts with http or https?

@the-djmaze
Copy link
Owner

the-djmaze commented Feb 14, 2023

No, because https://username:[email protected] is the only valid way.

In plain/text messages it is already hard enough to replace text in links.

@Zero3K
Copy link
Author

Zero3K commented Feb 14, 2023

Okay.

@the-djmaze the-djmaze added bug Something isn't working and removed wontfix This will not be worked on labels Feb 21, 2023
@the-djmaze
Copy link
Owner

I've misread the RFC!
In the beginning the @ is marked as reserved, but while reading at the end the BNF notation says otherwise.

hsegment       = *[ uchar | ";" | ":" | "@" | "&" | "=" ]
search         = *[ uchar | ";" | ":" | "@" | "&" | "=" ]

So i will fix the parser.

@the-djmaze
Copy link
Owner

While at it, i also allow unicode in them like: https://➡.ws/䨹 and http://उदाहरण.परीक्षा

the-djmaze pushed a commit that referenced this issue Feb 23, 2023
the-djmaze pushed a commit that referenced this issue Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants