chore: upgrade libs, node 20

[sammcj]

Upgraded repo to support current stable nodeJS and libraries.

• node 16 -> node 20
• actions-github v5 -> v6
• corrected input types (true != "true")

[iamludal]

Hi @aurelien-baudet , any updates on this PR please? Thanks.

[aurelien-baudet]

It seems ok, just a question

[aurelien-baudet]

Why did you add quotes ? It should be a boolean value

[figroc]

Should this line be changed? https://github.com/aurelien-baudet/workflow-dispatch/blob/c2b3c6dfb91343cf66073ac553e613483b046e1c/src/utils.ts#L44

[aurelien-baudet]

Not really, why ?

[Djontleman]

It should be a boolean value

Looking at the schema, the type of default is string. However, I don't think it will actually change any behaviour as GHA likely coerces it into a string anyway. This StackOverflow answer may also help explain.

It may be worth adding the quotes if only to avoid your editor showing a syntax error, but it should probably then use single-quotes to be consistent with the rest of the file.

Should this line be changed?

I also don't think this line should be changed. Whether the input is processed as a string or boolean is dependent on whether core.getInput or core.getBooleanInput is used in the script: https://www.npmjs.com/package/@actions/core#inputsoutputs

[aurelien-baudet]

Same here, why ?

[figroc]

And this: https://github.com/aurelien-baudet/workflow-dispatch/blob/c2b3c6dfb91343cf66073ac553e613483b046e1c/src/utils.ts#L49

[VincentLanglet]

What's the status of the PR ?

Also, there is a warning with the action:

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

[MugishaU]

Also wondering if there is any update on this?

[aurelien-baudet]

Sorry, I have no more time and energy to maintain this repository. I even don't have computer anymore. Someone of you should for this repository and merge the different pull requests.
Tell me who creates the fork and I will archive this repository but indicate which repository follows up

[iamludal]

Hi @aurelien-baudet, I have created a fork of your repository that I can maintain. https://github.com/iamludal/workflow-dispatch

[VincentLanglet]

Hi @aurelien-baudet, I have created a fork of your repository that I can maintain. iamludal/workflow-dispatch

Does this project really need another fork when there is already the original repository ?
https://github.com/benc-uk/workflow-dispatch

The original repository seems still maintained. Is there a reason to not for moving to it ?

[iamludal]

Hi @aurelien-baudet, I have created a fork of your repository that I can maintain. iamludal/workflow-dispatch

Does this project really need another fork when there is already the original repository ? https://github.com/benc-uk/workflow-dispatch

The original repository seems still maintained. Is there a reason to not for moving to it ?

Yes, this fork from @aurelien-baudet adds some inputs to wait for the workflow completion before exiting. In the original repository, the workflow is triggered and exits successfully immediately.

[VincentLanglet]

Yes, this fork from @aurelien-baudet adds some inputs to wait for the workflow completion before exiting. In the original repository, the workflow is triggered and exits successfully immediately.

Thanks for the answer.

IMHO the best, if possible, would be to add those inputs in the original repository which are well maintained.

I'll ask the original repo if he's interested benc-uk#73

[iamludal]

Yes, this fork from @aurelien-baudet adds some inputs to wait for the workflow completion before exiting. In the original repository, the workflow is triggered and exits successfully immediately.

Thanks for the answer.

IMHO the best, if possible, would be to add those inputs in the original repository which are well maintained.

I'll ask the original repo if he's interested benc-uk#73

I agree with you, I would prefer this solution over having to maintain a fork myself. I can do it if needed, but this is not the best solution.

[aurelien-baudet]

Repository transferred to https://github.com/the-actions-org/workflow-dispatch

[fbiesse]

These issues were resolved in #18