Fix for img padding #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the *img* has any *padding*, they should be considered as well. Otherwise the magnifying lense is displayed incorrectly. This is required, in some cases *img* tags are used with *box-sizing* set to *border-box* and padding added, which reduces the total size of which an image is displayed. Using jQuery's *innerWidth* and *innerHeight* instead of *width* and *height* has no effect if the *img* has no padding, but it fixed the mentioned problems if *img* has *padding*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the img has any padding, they should be considered as well. Otherwise the magnifying lense is displayed incorrectly.
This is required, in some cases img tags are used with box-sizing set to border-box and padding added, which reduces the total size of which an image is displayed.
Using jQuery's innerWidth and innerHeight instead of width and height has no effect if the img has no padding, but it fixed the mentioned problems if img has padding.