Skip to content

chore(dropdown): updated isflipenabled default logic #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcoker wants to merge 1 commit into from
Closed

chore(dropdown): updated isflipenabled default logic #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Dropdown/Dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export const Dropdown: React.FunctionComponent<DropdownProps> = ({
alignments,
contextProps,
menuAppendTo = 'inline',
isFlipEnabled = true,
isFlipEnabled = null,
removeFindDomNode = false,
...props
}: DropdownProps) => (
Expand Down
9 changes: 5 additions & 4 deletions packages/react-core/src/components/Dropdown/DropdownWithContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class DropdownWithContext extends React.Component<DropdownProps & OUIAPro
onSelect: (): void => undefined,
autoFocus: true,
menuAppendTo: 'inline',
isFlipEnabled: true
isFlipEnabled: null
};

constructor(props: DropdownProps & OUIAProps) {
Expand Down Expand Up @@ -93,7 +93,8 @@ export class DropdownWithContext extends React.Component<DropdownProps & OUIAPro
renderedContent = React.Children.toArray(children);
}
const openedOnEnter = this.openedOnEnter;
const isStatic = isFlipEnabled;
const isInline = menuAppendTo === 'inline';
const isStatic = !isInline && isFlipEnabled === null;
return (
<DropdownContext.Consumer>
{({ baseClass, baseComponent, id: contextId, ouiaId, ouiaComponentType, ouiaSafe, alignments }) => {
Expand Down Expand Up @@ -155,7 +156,7 @@ export class DropdownWithContext extends React.Component<DropdownProps & OUIAPro
}
})
)}
{menuAppendTo === 'inline' && isOpen && menuContainer}
{isInline && isOpen && menuContainer}
</BaseComponent>
);
const getParentElement = () => {
Expand All @@ -164,7 +165,7 @@ export class DropdownWithContext extends React.Component<DropdownProps & OUIAPro
}
return null;
};
return menuAppendTo === 'inline' ? (
return isInline ? (
mainContainer
) : (
<Popper
Expand Down