Query: Support match filter in labels API #7380
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Walther Lee <[email protected]>
waltherlee
changed the title
Signed-off-by: Walther Lee <[email protected]>
Contributor
|
Does this duplicate #7371? |
Contributor
Author
|
@MichaHoffmann Yes, it does. Thanks for noticing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The querier seems to ignore the
matchparam in the labels API. Requests are sent to all the stores, even if their external labels don't match the values specified in the matchers.Changes
Add support for
matchparam by passing the req matchers tostoreMatches. I think it should have a similar implementation to Series, where the querier select labels are excluded. It also returns an empty result if the matchers don't match the selector labels.Verification
I added new tests and confirmed that the proxy ignored the matchers, and requests were fanning out to all the stores even if their external labels didn't match.