chore: add size to iter with attributes #218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
reviewed
Sep 3, 2025
Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann/add-size-to-iter-with-attributes
branch
from
9bcf9fb to
3eea046
Compare
Yeah we can do that! Ill also implement it for the other providers a bit later! |
saswatamcode
reviewed
Sep 3, 2025
| for _, blob := range resp.Segment.BlobItems { | ||
| attrs := objstore.IterObjectAttributes{ | ||
| Name: *blob.Name, | ||
| Size: *blob.Properties.ContentLength, |
There was a problem hiding this comment.
SizeBytes would be preferable, I think!
GiedriusS
reviewed
Sep 3, 2025
|
|
||
| type IterObjectAttributes struct { | ||
| Name string | ||
| Size int64 |
There was a problem hiding this comment.
Can the size be negative? Maybe let's use uint64.
There was a problem hiding this comment.
Maybe as a canary for "this provider does not expose a size in iter"; idk if there is such a provider though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Verification