Checkout PR before updating changelog - fixes #732 #735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #732
Context / Background
When triggered, the
Changelog Updater
should update-commit-push the changelog file on the PR's source branch itself rather than themain
branch. This will ensure that the changes from the PR as well as the changelog update flow together tomain
branch.What change is being introduced by this PR?
ChangelogUpdater.yml
pull_request
trigger.2. Added
prefix_only: 'true'
for step withid: check
.3. Added
Checkout the pull request
step.pull_request
trigger, we should limit it to PRs againstmain
branch.2. The updater should not be triggered if the triggering message format is part of an
issue_comment
event that was not intended to trigger the bot (Example: if this issue message had been an issue_comment, the bot would have triggered erroneously). However, this will take effect only after prefix_only doesn't work - issue #18 on pull-request-comment-trigger repo is fixed.3. This will switch to the PR's source branch before updating the changelog. More info can be found on this link.
CONTRIBUTING.md
How will this be tested?
Once this PR is merged:
Changelog Updater
should be triggered by posting a comment as mentioned in Changelog update workflow should push to PR branch instead of main #732.Changelog Updater
workflow should be inspected for the expected behaviour (as mentioned inContext / Background
above).main
branch by the bot.