Queue runner v2#1
Closed
Conni2461 wants to merge 1 commit into
Closed
Conversation
Conni2461
force-pushed
the
queue-runner-v2
branch
3 times, most recently
from
f97d7be to
8eb984f
Compare
mweinelt
reviewed
Jul 7, 2025
| RestartSec = "5s"; | ||
| ExecStart = lib.escapeShellArgs ( | ||
| [ | ||
| "${cfg.package}/bin/builder" |
There was a problem hiding this comment.
This should use the meta.mainProgram/lib.getExe facilities.
Conni2461
force-pushed
the
queue-runner-v2
branch
from
8eb984f to
e96e58b
Compare
mweinelt
reviewed
Jul 10, 2025
Comment on lines
+91
to
+113
| grpcAddress = lib.mkOption { | ||
| type = lib.types.singleLineStr; | ||
| default = "[::1]"; | ||
| description = "The IP address the grpc listener should bound to"; | ||
| }; | ||
|
|
||
| grpcPort = lib.mkOption { | ||
| description = "Which grpc port this app should listen on"; | ||
| type = lib.types.port; | ||
| default = 50051; | ||
| }; | ||
|
|
||
| restAddress = lib.mkOption { | ||
| type = lib.types.singleLineStr; | ||
| default = "[::1]"; | ||
| description = "The IP address the rest listener should bound to"; | ||
| }; | ||
|
|
||
| restPort = lib.mkOption { | ||
| description = "Which rest port this app should listen on"; | ||
| type = lib.types.port; | ||
| default = 8080; | ||
| }; |
There was a problem hiding this comment.
let's put these into a grpc and rest attrset, so all aspects are neatly separated like mtls.
Author
|
superseded by NixOS#790 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.