Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to accept self signed certificates #6

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Conversation

piechpatrick
Copy link
Contributor

TlsSkipVerification

Copy link
Owner

@th0th th0th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested a few changes, then we can merge.

Also, did you have chance to run the version with changes? Did it work for your case?

README.md Outdated Show resolved Hide resolved
action.yml Outdated
@@ -8,6 +8,8 @@ inputs:
description: "Debug flag"
disable_output:
description: "Disables outputting to stdout (useful if the logs are public, but you don't want to expose anything)"
tls_skip_verification:
description: "Skipping host TLS verification"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "Skipping host TLS verification"
description: "Skips TLS verification for the outgoing HTTP request to Rancher"

main.go Outdated Show resolved Hide resolved
@th0th th0th linked an issue Mar 16, 2023 that may be closed by this pull request
@piechpatrick
Copy link
Contributor Author

i hope all looks great atm

@th0th th0th merged commit 680e203 into th0th:main Mar 16, 2023
@th0th
Copy link
Owner

th0th commented Mar 16, 2023

Thanks.

@th0th th0th changed the title TlsSkipVerification Add option to accept self signed certificates Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Client- SSL validation
2 participants