-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Gun Sound Overhaul #5261
Merged
Merged
The Gun Sound Overhaul #5261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched current license to CC-BY-NC-SA 3.0/Creative Commons Attribution-NonCommercial-ShareAlike 3.0 United States |
Awaiting review... |
TiviPlus
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok fuck it its good enough
Hughgent
approved these changes
Nov 21, 2020
Co-authored-by: Hughgent <[email protected]>
TiviPlus
approved these changes
Nov 22, 2020
tgstation-server
added a commit
that referenced
this pull request
Nov 23, 2020
This was referenced Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Sound
Sound change.
Test Merge Candidate
This PR has been reviewed and is ready for testing, unless something changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Reoverhauls almost every gun sound in the game, replacing every sound that was from CM or making the sounds from other games less noticeable. This also adds unique sounds to the dropship weapons, as well replacing the empty gun sound with a new one.
All sounds are from (if I remember correctly):
Call of Duty series
Halo series
Insurgency
Counter Strike: Global Offensive
Team Fortress 2
Ghost in the Shell Stand Alone Complex - First Assault Online
Fallout series
And others that I forgot.
Along with some of the original CM sounds.
All (new) sounds are from their respective owners, and I (and the entire community) do not take ownership from these sounds, mixed or not. They use the CC-BY-NC-SA 3.0/Creative Commons Attribution-NonCommercial-ShareAlike 3.0 United States license.
If any IP wants me to remove those sounds mixed in with the original ones, I would be glad to oblige.
Why It's Good For The Game
Because for me, I'm getting sort of tired hearing CM sounds in TGMC, so we're bringing something unique.
Changelog
🆑
tweak: Completely OVERHAULS almost all of the useable weapons, adding new ones...
del: ... and removing unused sounds or sounds from the leaked CM codebase.
tweak: All sounds now have consistent volume. Not all weapon sounds are changed.
tweak: The gunship's weapons now use a unique sound when firing
tweak: Changed the empty reloading sound.
tweak: Changed the *salute emote.
tweak: If you like/love the sounds, great. But if you don't like it, I respect your opinion.
tweak: All sounds use the CC-BY-NC-SA 3.0/Creative Commons Attribution-NonCommercial-ShareAlike 3.0 United States license. See PR for list of sounds used.
tweak: Fixed minor typos.
/:cl: