Turn the Fit… wrapper views into ViewModifiers
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know why this wasn't done like this to begin with, as `ViewModifier` is clearly the way to go. The wrapper variants an now soft-deprecated (which means that they won't be proposed by Xcode when autocompleting, but they won't show warnings). `WithLayoutMargins` is not concerned and is not soft-deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why this wasn't done like this to begin with, as
ViewModifieris clearly the way to go.The wrapper variants an now soft-deprecated (which means that they won't be proposed by Xcode when autocompleting, but they won't show warnings).
WithLayoutMarginsis not concerned and is not soft-deprecated.