Add OSSignposter
sugar and make Logger
not fail when testing.
#51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logger dependency fails when testing. We can't inspect messages that are logged and this dependency is so ubiquitous that it can be cumbersome to have to override it for every tests. It is thus probably preferable to make this dependency work without failing by default when testing. Users who want to assert that no logging occur can override the
\.logger
dependency with the.unimplemented
value.This commit also exposes some sugar to directly derive an
OSSignposter
value from aLogger
. Its API suffers the same limitations ofLogger
regarding privacy, so, likeLogger
, we can't create a configurable/inspectable wrapper of this type. For this reason, the dependency directly produces anOSSignposter
value.You can use the provided subscript to emit signposts on any subsystem/category: