Skip to content

release: engine events, Lua subscribe, ConsoleCommands and shutdown lifetime - #57

Merged
tgiachi merged 14 commits into
mainfrom
develop
Jul 3, 2026
Merged

release: engine events, Lua subscribe, ConsoleCommands and shutdown lifetime#57
tgiachi merged 14 commits into
mainfrom
develop

Merge pull request #56 from tgiachi/feature/lifetime

a5db8af
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Jul 3, 2026 in 6s

8 new alerts

New alerts in code changed by this pull request

  • 2 warnings
  • 6 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 35 in tests/SquidStd.Tests/Scripting/Lua/LuaEventBusForwarderTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dispose may not be called if an exception is thrown during execution Warning test

Dispose missed if exception is thrown by
call to method DoString
Loading
.
Dispose missed if exception is thrown by
call to method Register
Loading
.
Dispose missed if exception is thrown by
call to method Equal
Loading
.
Dispose missed if exception is thrown by
call to method Get
Loading
.

Check warning on line 75 in tests/SquidStd.Tests/Scripting/Lua/LuaEventBusForwarderTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dispose may not be called if an exception is thrown during execution Warning test

Dispose missed if exception is thrown by
call to method DoString
Loading
.
Dispose missed if exception is thrown by
call to method Register
Loading
.
Dispose missed if exception is thrown by
call to method Select<Int32,Task>
Loading
.
Dispose missed if exception is thrown by
call to method Range
Loading
.
Dispose missed if exception is thrown by
call to method WhenAll
Loading
.
Dispose missed if exception is thrown by
call to method Equal
Loading
.
Dispose missed if exception is thrown by
call to method Get
Loading
.

Check notice on line 73 in src/SquidStd.ConsoleCommands/Services/CommandSystemService.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed opportunity to use Where Note

This foreach loop
implicitly filters its target sequence
Loading
- consider filtering the sequence explicitly using '.Where(...)'.

Check notice on line 165 in src/SquidStd.ConsoleCommands/Services/CommandSystemService.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 91 in src/SquidStd.Scripting.Lua/Services/LuaEventBusForwarder.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 31 in src/SquidStd.Services.Core/Services/Bootstrap/SquidStdBootstrap.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed 'using' opportunity Note

This variable is manually
disposed
Loading
in a
finally block
Loading
- consider a C# using statement as a preferable resource management technique.

Check notice on line 218 in src/SquidStd.Services.Core/Services/Bootstrap/SquidStdBootstrap.cs

See this annotation in the file changed.

Code scanning / CodeQL

Poor error handling: empty catch block Note

Poor error handling: empty catch block.

Check notice on line 360 in src/SquidStd.Services.Core/Services/Bootstrap/SquidStdBootstrap.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.