feat(bootstrap): shared shutdown lifetime (ISquidStdLifetime)#56
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| private readonly List<(Type ConfigType, Action<object> Apply)> _configHooks = []; | ||
| private readonly List<Action<IConfigManagerService>> _configReadyCallbacks = []; | ||
| private readonly SquidStdLifetimeService _lifetime = new(); |
Comment on lines
+217
to
+218
| catch (OperationCanceledException) when (cancellationToken.IsCancellationRequested | ||
| || _lifetime.ShutdownToken.IsCancellationRequested) { } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of moongatev2's
ServerLifetimeService: a shared shutdown signal owned by the bootstrap. Closes the known follow-up "exitstops the services but aRunAsync-hosted app keeps waiting forever".ISquidStdLifetime(ShutdownToken+ idempotentRequestShutdown()), instance owned and ctor-registered by the bootstrap, disposed with it (post-disposeRequestShutdownis a safe no-op).RunAsyncnow waits on a token linked to the caller token AND the shutdown token -RequestShutdown()ends the run with the ordered stop (engine events + lifecycle logs included).Console.CancelKeyPressrequests the shutdown instead of killing the process; a second Ctrl+C during shutdown still force-quits (handler removed before the stop).exitis lifetime-first (fallback to the old directStopAsyncwhen no lifetime is registered - bare-container hosts). With aRunAsynchost,exitnow terminates the process cleanly. ManualStartAsynchosts: observeShutdownTokenyourself (documented).Test Plan
EngineStoppedEventobserved; idempotency; caller-token regression) + lifetime-first exit test (token cancelled, no direct bootstrap stop)exitand Ctrl+C on a RunAsync host - not automatable in CI