Skip to content

fix(ci): make version test survive release bumps#3

Merged
tgiachi merged 3 commits into
mainfrom
develop
Jun 22, 2026
Merged

fix(ci): make version test survive release bumps#3
tgiachi merged 3 commits into
mainfrom
develop

Conversation

@tgiachi

@tgiachi tgiachi commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Summary

Greens up main CI after the v0.2.0 release. The only failure was a brittle test:
VersionUtilsTests asserted the version starts with the hardcoded 0.1.0, which broke once
semantic-release bumped the assembly version to 0.2.0. It now asserts the version shape
(^\d+\.\d+\.\d+) instead of a literal, so it survives every release bump.

Also includes a small code-convention refactor (stop null-checking DI constructor dependencies).

Release impact

Commits since v0.2.0: 1 test, 1 refactor — no feat/fix, so no new release is produced; this
merge only re-runs CI green on main.

Test plan

  • VersionUtilsTests pass locally (3/3)
  • On merge: CI on main is green; semantic-release no-ops (no version bump)

tgiachi added 2 commits June 22, 2026 17:23
…tion)

- CacheService: drop ArgumentNullException.ThrowIfNull(options)
- TimerWheelPumpService: drop ThrowIfNull(config)
- RabbitMqQueueProvider: drop ThrowIfNull(options/messagingOptions)
the container validates required services per project convention
@github-advanced-security

Copy link
Copy Markdown
Contributor

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@tgiachi
tgiachi merged commit 2e8e853 into main Jun 22, 2026
3 checks passed
tgiachi added a commit that referenced this pull request Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants