Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/SquidStd.Tui/Extensions/RegisterTuiExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@ public IContainer RegisterView<TView, TViewModel>()
where TView : class, ITuiView
where TViewModel : TuiViewModel
{
container.Register<TView>(Reuse.Transient);
// Views derive from Window (IDisposable). DryIoc refuses disposable transients by default;
// allow it without tracking — the view host disposes each view on Remove, so the container
// must not also dispose it (which would double-dispose).
container.Register<TView>(Reuse.Transient, setup: Setup.With(allowDisposableTransient: true));
container.Register<TViewModel>(Reuse.Transient);
container.Resolve<TuiViewRegistry>().Map(typeof(TViewModel), typeof(TView));

Expand Down
28 changes: 28 additions & 0 deletions tests/SquidStd.Tests/Tui/Extensions/RegisterTuiExtensionsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,22 @@
}
}

// Real views derive from Window (IDisposable); this fake reproduces that shape.
private sealed class DisposableView : ITuiView, IDisposable
{
public void Bind(object viewModel)
{
}

public void Initialize()
{
}

public void Dispose()
{
}
}

[Fact]
public void RegisterTui_RegistersNavigatorAndRegistry()
{
Expand All @@ -50,4 +66,16 @@
Assert.NotNull(container.Resolve<HomeViewModel>());
Assert.NotNull(container.Resolve<HomeView>());
}

[Fact]
public void RegisterView_AllowsDisposableTransientView()
{
var container = new Container();

Check warning

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning test

Disposable 'Container' is created but not disposed.
container.RegisterTui();

// Real views are IDisposable (Window); DryIoc throws on disposable transients unless allowed.
container.RegisterView<DisposableView, HomeViewModel>();

Assert.NotNull(container.Resolve<DisposableView>());
}
}
Loading