Correctly copy the null terminator

Fixes #714
tfussell · Sep 23, 2023 · 33dd551 · 33dd551
1 parent 297b331
commit 33dd551
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 1 deletion.
diff --git a/include/xlnt/utils/numeric.hpp b/include/xlnt/utils/numeric.hpp
@@ -176,7 +176,8 @@ class number_serialiser
         }
         char buf[30];
         assert(s.size() < sizeof(buf));
-        auto copy_end = std::copy(s.begin(), s.end(), buf);
+        const char *cstr = s.c_str();
+        auto copy_end = std::copy(cstr, cstr + s.size() + 1, buf);
         convert_pt_to_comma(buf, static_cast<size_t>(copy_end - buf));
         double d = strtod(buf, &end_of_convert);
         *len_converted = end_of_convert - buf;

diff --git a/tests/data/Issue714_local_comma.xlsx b/tests/data/Issue714_local_comma.xlsx
diff --git a/tests/detail/numeric_util_test_suite.cpp b/tests/detail/numeric_util_test_suite.cpp
@@ -23,6 +23,7 @@
 
 #include <xlnt/utils/numeric.hpp>
 #include <helpers/test_suite.hpp>
+#include <cstring>
 
 class numeric_test_suite : public test_suite
 {
@@ -36,6 +37,7 @@ class numeric_test_suite : public test_suite
         register_test(test_min);
         register_test(test_max);
         register_test(test_abs);
+        register_test(test_locale_comma);
     }
 
     void test_serialise_number()
@@ -219,5 +221,18 @@ class numeric_test_suite : public test_suite
 
         static_assert(xlnt::detail::abs(-1.23) == 1.23, "constexpr");
     }
+
+    void test_locale_comma ()
+    {
+        struct SetLocale
+        {
+            SetLocale() {xlnt_assert(setlocale(LC_ALL, "de_DE") != nullptr);} // If failed, please install de_DE locale to correctly run this test.
+            ~SetLocale() {setlocale(LC_ALL, "C");}
+        } setLocale;
+
+        xlnt::detail::number_serialiser serialiser;
+        xlnt_assert(serialiser.deserialise("1.99999999") == 1.99999999);
+        xlnt_assert(serialiser.deserialise("1.1") == 1.1);
+    }
 };
 static numeric_test_suite x;
diff --git a/tests/workbook/serialization_test_suite.cpp b/tests/workbook/serialization_test_suite.cpp
@@ -73,6 +73,7 @@ class serialization_test_suite : public test_suite
         register_test(test_Issue503_external_link_load);
         register_test(test_formatting);
         register_test(test_active_sheet);
+        register_test(test_locale_comma);
     }
 
     bool workbook_matches_file(xlnt::workbook &wb, const xlnt::path &file)
@@ -808,6 +809,21 @@ class serialization_test_suite : public test_suite
         wb.load(path_helper::test_file("20_active_sheet.xlsx"));
         xlnt_assert_equals(wb.active_sheet(), wb[2]);
     }
+
+    void test_locale_comma ()
+    {
+        struct SetLocale
+        {
+            SetLocale() {xlnt_assert(setlocale(LC_ALL, "de_DE") != nullptr);} // If failed, please install de_DE locale to correctly run this test.
+            ~SetLocale() {setlocale(LC_ALL, "C");}
+        } setLocale;
+
+        xlnt::workbook wb;
+        wb.load(path_helper::test_file("Issue714_local_comma.xlsx"));
+        auto ws = wb.active_sheet();
+        xlnt_assert_equals(ws.cell("A1").value<double>(), 1.9999999999);
+        xlnt_assert_equals(ws.cell("A2").value<double>(), 1.1);
+    }
 };
 
 static serialization_test_suite x;