-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash with read-only polymorphic sub-serializer. #542
Conversation
If all fields are read-only when using split requests the component is pruned from the registry and if no longer available. If that is the case, we should just skip that component.
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
- Coverage 98.71% 98.69% -0.03%
==========================================
Files 57 57
Lines 6302 6343 +41
==========================================
+ Hits 6221 6260 +39
- Misses 81 83 +2
Continue to review full report at Codecov.
|
Thanks for the tidy up! Glad I was able to track this one down though 🙂 |
nice find @ngnpope! I also added a fix for |
i see that you pretty much use all the features in spectacular. glad to see that! i'm quite amazed at how seasoned code that is likely used by a bunch of people still can contain simple bugs. |
If all fields are read-only when using split requests the component is pruned from the registry and if no longer available. If that is the case, we should just skip that component.