Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags support to OpenApiWebhook #1146

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

federicobond
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db414d6) 98.58% compared to head (2c997a8) 98.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1146   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          72       72           
  Lines        8766     8769    +3     
=======================================
+ Hits         8642     8645    +3     
  Misses        124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfranzel
Copy link
Owner

I'll merge this for completeness sake. Webhooks use the same operation object as regular endpoints and so tags are also possible here. However, at least Swagger UI ignores it currently.

@tfranzel tfranzel merged commit f9f0336 into tfranzel:master Feb 19, 2024
35 checks passed
@federicobond
Copy link
Contributor Author

I don't know about Swagger UI, but Redoc uses tags for webhooks and I am using them in production.

@federicobond federicobond deleted the webhook-tags branch February 19, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants