-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to alex@11 #25
Conversation
I tried the changes you suggests but I am still getting errors. |
Thanks. Ah, I've created an issue to upstream textlint/textlint#1283 Edit: fixed in https://github.com/textlint/textlint/releases/tag/v13.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some packages require Node.js 16+.
Please update CI's node-version
.
(Node.js 16 is already End Of Support. So we can put 18+)
- node-version: [12, 14]
+ node-version: [18, 20]
node-version: [12, 14] |
I commented. Probably need to run following command.
yarn add alex
yarn add textlint-scripts --dev
yarn upgrade # need to update lock file
Now getting error: Still get |
Yes, It is required.
https://github.com/textlint/textlint/releases/tag/v13.4.0 fix this issue.
|
Co-authored-by: azu <[email protected]>
This error caused by old 📝 |
Hmmm ... tests passed at e27b519. |
Yes. This workflow includes
|
Fmm. its something wrong. |
I've fixed in 9f7a8f7
CI is passed 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your patience in proceeding!
9f7a8f7 fixes local testing for me too. |
Yay! 🎊 Thank you very much for your help, guidence and patience. |
|
Fixes #17
This PR bumps the dependencies required to prevent Dependabot notifications.