Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update analyze-dearu-desumasu to 4.0.0 #19

Merged
merged 3 commits into from
Sep 29, 2018
Merged

Update analyze-dearu-desumasu to 4.0.0 #19

merged 3 commits into from
Sep 29, 2018

Conversation

0x6b
Copy link
Contributor

@0x6b 0x6b commented Sep 29, 2018

Closes #18.

  • I added house-keeping scripts such as husky, lint-staged, prettier for easier contribution for me (db28871). But let me know if you need another issue and/or pull request for the change since it generates a bunch of diffs which is not directly related to Upgrade to [email protected] #18.
  • I'm a bit wondering my additional test cases 7c8a518 are valid or comprehensive. Please review and give me your comment if any.

azu
azu approved these changes Sep 29, 2018
View reviewed changes
Copy link
Member

@azu azu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azu azu merged commit 55041b3 into textlint-ja:master Sep 29, 2018
@0x6b 0x6b deleted the update-analyze-dearu-desumasu branch September 29, 2018 04:33
@azu azu mentioned this pull request Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azu azu azu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x6b @azu