feat: make the rule fixable #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unicode assigns corresponding full-width characters to the characters covered by this rule, so they can be converted to full-width using NFKC or NFKD normalization.
https://unicode.org/charts/PDF/UFF00.pdf
The figure shows that U+FF61 is narrow version of U+3002 i.e. corresponding full-width character for U+FF61 is U+3002.
In this pull request, I have implemented a fixer using NFKC.
Due to the mechanism of NFKC, voiced and semi-voiced marks that can be expressed in NFC are represented in NFC, while those that cannot be expressed in NFC become NFD.