Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add separator characters #6

Closed
wants to merge 2 commits into from

Conversation

bean1310
Copy link

@bean1310 bean1310 commented Feb 2, 2021

Hello.

This PR adds "."(period) & "."(Zenkaku period) as separator characters to detect double conjunction in sentences that use these.
These are added in textlint-ja/textlint-rule-no-doubled-joshi already.

Note :
According to the IPSJ journal, Using “zenkaku period” is recommended.

コンマおよびピリオドの使い方:
 ・和文には、全角コンマ、全角コロン、全角ピリオドを用いる。

azu added a commit that referenced this pull request Apr 25, 2021
@azu azu closed this in #8 Apr 25, 2021
azu added a commit that referenced this pull request Apr 25, 2021
## Summary

- Update to [kuromojin@3](https://github.com/azu/kuromojin/releases/tag/v3.0.0) and improve analysis.
- 全角ピリオド(`.`)の対応 fix #6 
- エラーメッセージの改善

## Features

- 全角ピリオド(`.`)の対応 fix #6 
- エラーメッセージの改善

##  Bug Fixes

- Update to [kuromojin@3](https://github.com/azu/kuromojin/releases/tag/v3.0.0)
  - refs azu/kuromojin#8
- Update to [sentence-splitter@3](https://github.com/azu/sentence-splitter/releases/tag/3.0.0)

## CI

- Move to GitHub Actions
@azu
Copy link
Member

azu commented Apr 25, 2021

https://github.com/textlint-ja/textlint-rule-no-doubled-conjunction/releases/tag/v2.0.0
で対応いたしました

@bean1310 bean1310 deleted the add-separator-char branch April 25, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants