Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update kuromojin@3 and fix max option #11

Merged
merged 1 commit into from
Apr 24, 2021
Merged

fix: update kuromojin@3 and fix max option #11

merged 1 commit into from
Apr 24, 2021

Conversation

azu
Copy link
Member

@azu azu commented Apr 24, 2021

Summary

の検知が改善されるため、既存の文章でもエラーが増える場合があります。
max オプションの実装がREADMEとずれていたため、READMEに合わせるように修正しました。

  • 3.0.0: max: 3 なら 一文に3つ以上の読点でエラーとなる
  • 4.0.0: max: 3 なら 一文に4つ以上の読点でエラーとなる

Fixes

名詞同士に例外にかかっていてカウントが上手く行かないケースがあったため、max のズレる問題に気づきにくかったようです。

@azu azu merged commit b69c090 into master Apr 24, 2021
@azu azu deleted the kuromojin@3 branch April 24, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant