Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(analyze): support masu #9

Merged
merged 3 commits into from
Sep 27, 2018
Merged

fix(analyze): support masu #9

merged 3 commits into from
Sep 27, 2018

Conversation

0x6b
Copy link
Contributor

@0x6b 0x6b commented Sep 27, 2018

Closes #8.

azu
azu approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@azu azu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I will release it as major update.
Because, This change will break https://github.com/textlint-ja/textlint-rule-no-mix-dearu-desumasu 's behavior.
(Probably, report new lint error to existing user)

@azu azu merged commit 5170fb8 into textlint-ja:master Sep 27, 2018
@azu
Copy link
Member

azu commented Sep 27, 2018

Release https://github.com/azu/analyze-desumasu-dearu/releases/tag/4.0.0

@azu azu mentioned this pull request Sep 27, 2018
Closed
@0x6b
Copy link
Contributor Author

0x6b commented Sep 28, 2018 •
edited
Loading

Hi @azu, thanks for the new release. Following line in the release note should be "ます"?

isDesumasu inclues です.

@0x6b 0x6b deleted the support-masu branch September 28, 2018 00:23
@azu
Copy link
Member

azu commented Sep 28, 2018

Ah, I miss it.
Fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azu azu azu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x6b @azu