Skip to content

fix(base-cluster/metrics-server): remove mount, as it's fixed via chart#818

Merged
marvinWolff merged 2 commits intomainfrom
fix/metrics-server-mount
Mar 15, 2024
Merged

fix(base-cluster/metrics-server): remove mount, as it's fixed via chart#818
marvinWolff merged 2 commits intomainfrom
fix/metrics-server-mount

Conversation

@marvinWolff
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

@tasches tasches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and reviewed. Fixes the issue with the double /tmp mount

Copy link
Copy Markdown
Collaborator

@tasches tasches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you update the readme with the new major version in the cluster bootstrap section

@tasches tasches linked an issue Mar 6, 2024 that may be closed by this pull request
@cwrau
Copy link
Copy Markdown
Member

cwrau commented Mar 7, 2024

could you update the readme with the new major version in the cluster bootstrap section

What major version in the bootstrap section do you mean? This one?

If yes, that doesn't really have anything to do with this, no?

@tasches
Copy link
Copy Markdown
Collaborator

tasches commented Mar 7, 2024

could you update the readme with the new major version in the cluster bootstrap section

What major version in the bootstrap section do you mean? This one?

If yes, that doesn't really have anything to do with this, no?

yes. In that section. There are two occurrences of the base-cluster chart version. First in the flux create helmrelease ....
and in the helm install ... command.

@teutonet-bot
Copy link
Copy Markdown
Contributor

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

charts/base-cluster/ci/monitoring-ingress-unauthenticated-values.yaml has no changes

charts/base-cluster/ci/rbac-values.yaml has no changes

charts/base-cluster/ci/pagerduty-values.yaml has no changes

charts/base-cluster/ci/imagepullsecrets-values.yaml has no changes

charts/base-cluster/values.yaml has no changes

charts/base-cluster/ci/artifacthub-values.yaml has no changes

charts/base-cluster/ci/disabled-ingress-values.yaml has no changes

[charts/base-cluster/ci/flux-gitrepositories-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>
    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help/"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about/"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 2,443,796
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>
)

charts/base-cluster/ci/priorityclasses-values.yaml has no changes

[charts/base-cluster/ci/deadmansswitch-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>
    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help/"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about/"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 1,982,661
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>
)

charts/base-cluster/ci/monitoring-oidc-values.yaml has no changes

[charts/base-cluster/ci/basic-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>
    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help/"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about/"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 1,977,313
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>
)

charts/base-cluster/ci/monitoring-oidc-ingress-disabled-values.yaml has no changes

[charts/base-cluster/ci/limitrange-resourcequota-values.yaml](

<title> Error </title> <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script> <script defer src="https://media.ethicalads.io/media/client/ethicalads.min.js"></script> <script> function key(event, letter) { return (event.charCode == letter.charCodeAt() || event.charCode == letter.charCodeAt() + 32) } </script>
    <script>
        
        
    </script>
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/normalize.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/skeleton.css">
    <link rel="stylesheet" href="https://dpaste.b-cdn.net/static/pastebin/css/main.css">
    <link href="https://fonts.googleapis.com/css2?family=Fira+Sans:wght@400;700&amp;display=swap"
          rel="stylesheet">
    <link href="https://fonts.googleapis.com/css?family=Fira+Mono"
          rel="stylesheet">
    <style></style>
</head>
<body>
    <div id="container">
        
        <div class="topbuttons">
            
                <a href="/accounts/login/"
                   title="Personal dashboard, preferences, API token"
                   class="button"><b>Sign in</b></a>
            
            <a href="/" title="Create a new paste" class=" button">New</a>
            <a href="/api/v2/"
               title="Paste creation API, with code samples"
               class=" activebutton  button">API</a>
            <a href="/help/"
               title="Usage tips, shortcuts"
               class="  button">Help</a>
            <a href="/about/"
               title="Updates, stats, backstory"
               class=" button">About</a>
        </div>
        
<div class="error">
    <h3>Sorry!</h3>
    Sorry, maximum paste size is 1,000,000 characters. Your submission is 2,000,406
    <hr>
    <p>
        Something unexpected? Please create a <a href="https://dpaste.freshdesk.com/support/tickets/new">support ticket</a>.
    </p>
</div>
<p>
    <a class="button" href="{$ url 'create' %}" onclick="history.back();return false;">Go back</a>
</p>

    </div>
    
    
    <script>
        window.fwSettings={'widget_id':22000000180 };
        !function(){if("function"!=typeof window.FreshworksWidget){var n=function(){n.q.push(arguments)};n.q=[],window.FreshworksWidget=n}}();
    </script>
    <script defer src='https://widget.freshworks.com/widgets/22000000180.js'></script>
</body>
)

charts/base-cluster/ci/velero-backupStorageLocations-values.yaml has no changes

@marvinWolff marvinWolff merged commit b8cbe36 into main Mar 15, 2024
@marvinWolff marvinWolff deleted the fix/metrics-server-mount branch March 15, 2024 11:37
marvinWolff pushed a commit that referenced this pull request Mar 27, 2024
🤖 I have created a release *beep* *boop*
---


##
[6.0.0](base-cluster-v5.0.1...base-cluster-v6.0.0)
(2024-03-25)


### ⚠ BREAKING CHANGES

* **base-cluster/kyverno:** upgrade 🤮
([#784](#784))

### Features

* add helmrelease schemas 😍
([#792](#792))
([89ed7eb](89ed7eb))
* **base-cluster:** enable cilium dns proxy
([#825](#825))
([73c97fa](73c97fa))
* **base-cluster:** upgrade all HRs and enable driftDetection
([#773](#773))
([fe6e71a](fe6e71a))


### Bug Fixes

* **base-cluster-schema/schema:** remove required for serviceLevelAgre…
([#791](#791))
([d9917b5](d9917b5))
* **base-cluster/grafana:** oidc secret handling
([#756](#756))
([73a15d2](73a15d2))
* **base-cluster/kyverno:** configure missing registry for kyverno
images
([#811](#811))
([83c44f5](83c44f5))
* **base-cluster/metrics-server:** remove mount, as it's fixed via chart
([#818](#818))
([b8cbe36](b8cbe36))
* **base-cluster/monitoring:** missing UIDs and cross-connections
([#824](#824))
([39b19d2](39b19d2))
* **base-cluster/oauth-proxy:** use correct secretName for certificate
([#758](#758))
([eda417c](eda417c))
* helmrelease-schemas
([#794](#794))
([6544385](6544385))


### Miscellaneous Chores

* **base-cluster/artifacthub-images:** Update ArtifactHUB images
([#786](#786))
([c9e14e4](c9e14e4))
* **base-cluster/backup:** pin velero, as they don't follow semver
([#781](#781))
([a87c79e](a87c79e))
* **base-cluster/dependencies:** update docker.io/bitnami/kubectl docker
tag to v1.29.3
([#788](#788))
([622ddd3](622ddd3))
* **base-cluster/dependencies:** update docker.io/curlimages/curl docker
tag to v8.6.0
([#753](#753))
([ae31961](ae31961))
* **base-cluster/dependencies:** update docker.io/fluxcd/flux-cli docker
tag to v2.2.3
([#764](#764))
([cf45276](cf45276))
* **base-cluster/dependencies:** update external-dns docker tag to v7
([#827](#827))
([1ea1bf9](1ea1bf9))
* **base-cluster/dependencies:** update grafana-tempo docker tag to v3
([#828](#828))
([7c0f9ba](7c0f9ba))
* **base-cluster/dependencies:** update helm release common to v2.16.1
([#782](#782))
([e6568d0](e6568d0))
* **base-cluster/dependencies:** update helm release common to v2.19.0
([#814](#814))
([5419c5c](5419c5c))
* **base-cluster/dependencies:** update helm release descheduler to
0.29.x
([#704](#704))
([61264cb](61264cb))
* **base-cluster/dependencies:** update helm release
kube-prometheus-stack to v57
([#820](#820))
([2e64dbe](2e64dbe))
* **base-cluster/dependencies:** update helm release velero to v5.4.1
([#798](#798))
([ab8a741](ab8a741))
* **base-cluster/dependencies:** update helm release velero to v6
([#812](#812))
([b09985e](b09985e))
* **base-cluster/dependencies:** update metrics-server docker tag to v7
([#821](#821))
([3ca7dbc](3ca7dbc))
* **base-cluster/kyverno:** upgrade 🤮
([#784](#784))
([1c62356](1c62356))
* **base-cluster:** streamline imagePullPolicy
([#757](#757))
([61f1c7f](61f1c7f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[base-cluster] metrics-server mount Error

4 participants