fix(t8s-cluster/management-cluster): prefix the autoscaler with as-

[cwrau]

Otherwise clusters starting with a number break the autoscaler service

Summary by CodeRabbit

• Chores
  • Updated autoscaler configuration in the cluster management template.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a5114349-0761-49f7-ad0d-5c49b6d53ffa

📥 Commits

Reviewing files that changed from the base of the PR and between db6bcbf and 65b58a6.

📒 Files selected for processing (1)

• charts/t8s-cluster/templates/management-cluster/autoscaler.yaml

---

📝 Walkthrough

Walkthrough

The autoscaler HelmRelease template now includes a fullnameOverride configuration parameter that generates predictable resource names in the format as-<release-name>-autoscaler, ensuring consistent naming across cluster deployments.

Changes

Autoscaler Configuration

Layer / File(s)	Summary
HelmRelease Fullname Override charts/t8s-cluster/templates/management-cluster/autoscaler.yaml	Added spec.values.fullnameOverride set to as-{{ .Release.Name }}-autoscaler for predictable autoscaler resource naming.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• teutonet/teutonet-helm-charts#1756: Modifies the HelmRelease in the autoscaler template with related fullnameOverride configuration.
• teutonet/teutonet-helm-charts#2002: Updates the same autoscaler HelmRelease template for replicas and maxReplicas handling.
• teutonet/teutonet-helm-charts#1760: Modifies management-cluster autoscaler HelmRelease configuration.

Suggested labels

t8s-cluster

Suggested reviewers

• tasches
• marvinWolff
• teutonet-bot

Poem

🐰 A scaler needs a name so true,
as-release-autoscaler through and through,
No more confusion in the cluster's dance,
With fullnameOverride, resources prance! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding an 'as-' prefix to the autoscaler HelmRelease name to fix issues with cluster names starting with numbers.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/t8s-cluster/autoscaler-names

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request updates the autoscaler template to include a fullnameOverride with an as- prefix, ensuring that generated resources comply with DNS-1035 standards by starting with a letter. The review feedback identifies an inconsistency where the HelmRelease name lacks this prefix and suggests quoting the template value to adhere to Helm best practices.

[Copilot]

Pull request overview

This PR updates the management-cluster cluster-autoscaler HelmRelease configuration to ensure the autoscaler’s rendered Kubernetes resource names don’t begin with a digit, avoiding name-derived constraints when a cluster/release name starts with a number.

Changes:

• Set values.fullnameOverride for the autoscaler HelmRelease to as-<release>-autoscaler to force a non-numeric prefix on autoscaler resource names.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.