chore(main): [bot] release common:3.0.0#2127
Conversation
teutonet-bot
requested review from
a team,
cwrau,
marvinWolff and
tasches
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the common helm chart to version 3.0.0, introducing a breaking change to CPU limits and several new features. Review feedback identifies critical implementation errors in the statefulset recreate job and helm repository templates, including undefined references and incorrect mustMerge usage. Additionally, the changelog requires corrections for redundant entries, an incorrect historical date, and a discrepancy regarding namespace configuration.
| * **common/networkpolicy:** add support for konnectivity-agent deployment ([#1901](https://github.com/teutonet/teutonet-helm-charts/issues/1901)) ([85ae79f](https://github.com/teutonet/teutonet-helm-charts/commit/85ae79f4665984a6900fd49e3118169e2c246818)) | ||
| * **common/resources:** drop cpu limits by default ([#1987](https://github.com/teutonet/teutonet-helm-charts/issues/1987)) ([d4564a5](https://github.com/teutonet/teutonet-helm-charts/commit/d4564a5a4e2d26853172cc79ae7fe47f291b03f0)) | ||
| * **common:** add function for retention ([#2126](https://github.com/teutonet/teutonet-helm-charts/issues/2126)) ([fe878fb](https://github.com/teutonet/teutonet-helm-charts/commit/fe878fbe7c342146180cc9875e23319a1623fbb8)) | ||
| * **common:** add statefulset recreate job ([#1723](https://github.com/teutonet/teutonet-helm-charts/issues/1723)) ([6f40d20](https://github.com/teutonet/teutonet-helm-charts/commit/6f40d204c3abb0ebea526ed2181786e10ad34b3a)) |
There was a problem hiding this comment.
The implementation of the statefulset recreate job in charts/common/templates/_statefulset_recreate_hook.yaml contains several critical issues:
- Undefined Template: Line 73 references
loki.baseImage, which is not defined in this chart. This will cause a rendering error during deployment. - Missing Value: Line 73 references
$.Values.global.image, but thevalues.yamlonly definesglobal.kubectl.image. - Incorrect
mustMergeUsage (Line 2): Violates the general rule where the destination dictionary must be the last argument. It is currentlymustMerge . (pick ...), which fails to update the local context as intended. - Side Effects (Line 63): The
mustMergecall merges the tag into$.Values.global.kubectl.image. Since this is a reference to the global values object, it modifies the values for the entire chart execution, which is a dangerous side effect.
| * **common/resources:** drop cpu limits by default ([#1987](https://github.com/teutonet/teutonet-helm-charts/issues/1987)) ([d4564a5](https://github.com/teutonet/teutonet-helm-charts/commit/d4564a5a4e2d26853172cc79ae7fe47f291b03f0)) | ||
| * **common:** add function for retention ([#2126](https://github.com/teutonet/teutonet-helm-charts/issues/2126)) ([fe878fb](https://github.com/teutonet/teutonet-helm-charts/commit/fe878fbe7c342146180cc9875e23319a1623fbb8)) | ||
| * **common:** add statefulset recreate job ([#1723](https://github.com/teutonet/teutonet-helm-charts/issues/1723)) ([6f40d20](https://github.com/teutonet/teutonet-helm-charts/commit/6f40d204c3abb0ebea526ed2181786e10ad34b3a)) | ||
| * **common:** centralise helmRepositories templating ([#1844](https://github.com/teutonet/teutonet-helm-charts/issues/1844)) ([31b1629](https://github.com/teutonet/teutonet-helm-charts/commit/31b1629c055b1807c8c4157b773b07076f109335)) |
There was a problem hiding this comment.
In charts/common/templates/_helmrepositories.tpl, the mustMerge call on line 2 (mustMerge . (pick ...)) violates the general rule where the destination dictionary should be the last argument. This prevents the local context from being correctly updated with the picked values.
|
|
||
| ### Features | ||
|
|
||
| * **common/helm:** add option to set namespace of HelmRepository ([#1757](https://github.com/teutonet/teutonet-helm-charts/issues/1757)) ([6efd87b](https://github.com/teutonet/teutonet-helm-charts/commit/6efd87b1cd1c032170e8d02138b007ee6c8c754c)) |
There was a problem hiding this comment.
The changelog entry mentions an option to set the namespace of HelmRepository, but the implementation in charts/common/templates/_helmrepositories.tpl (lines 14 and 29) appears to be hardcoded to $.Release.Namespace and does not utilize a configurable namespace from the repository configuration.
| ### Miscellaneous Chores | ||
|
|
||
| * **common/dependencies:** update helm release common to v2.31.4 ([#1532](https://github.com/teutonet/teutonet-helm-charts/issues/1532)) ([7df033f](https://github.com/teutonet/teutonet-helm-charts/commit/7df033f5fe807f53505f8fdf78ae1549632aac5e)) | ||
| * **common/dependencies:** update helm release common to v2.34.0 ([#1965](https://github.com/teutonet/teutonet-helm-charts/issues/1965)) ([af9e6b3](https://github.com/teutonet/teutonet-helm-charts/commit/af9e6b3a10287448ce0540b3520c3a32229c2605)) | ||
| * **common/dependencies:** update helm release common to v2.36.0 ([#1983](https://github.com/teutonet/teutonet-helm-charts/issues/1983)) ([0b5e540](https://github.com/teutonet/teutonet-helm-charts/commit/0b5e540ffdd0d610fc44c92361eca7e4cf395cd9)) | ||
| * **common/dependencies:** update helm release common to v2.38.0 ([#2062](https://github.com/teutonet/teutonet-helm-charts/issues/2062)) ([2eb5e2b](https://github.com/teutonet/teutonet-helm-charts/commit/2eb5e2b18b4ca12ecea709e3f0e187e4e39fc9ca)) | ||
| * **main:** [bot] release common:1.6.0 ([#1766](https://github.com/teutonet/teutonet-helm-charts/issues/1766)) ([f870cda](https://github.com/teutonet/teutonet-helm-charts/commit/f870cda53ebdddd7c543703d8d71edf093f48d18)) | ||
| * **main:** [bot] release common:1.7.0 ([#1787](https://github.com/teutonet/teutonet-helm-charts/issues/1787)) ([3014b2c](https://github.com/teutonet/teutonet-helm-charts/commit/3014b2c8df862a2902e800ae129f9b7429a04268)) | ||
| * **main:** [bot] release common:1.8.0 ([#1871](https://github.com/teutonet/teutonet-helm-charts/issues/1871)) ([d867cf7](https://github.com/teutonet/teutonet-helm-charts/commit/d867cf749da82c47775aa34716a957f9a68f0965)) | ||
| * **main:** [bot] release common:2.0.0 ([#1972](https://github.com/teutonet/teutonet-helm-charts/issues/1972)) ([f49144b](https://github.com/teutonet/teutonet-helm-charts/commit/f49144b7bcdbd58554993b47fa711ec52b05a52e)) | ||
| * **main:** [bot] release common:2.1.0 ([#2068](https://github.com/teutonet/teutonet-helm-charts/issues/2068)) ([b9f4bf8](https://github.com/teutonet/teutonet-helm-charts/commit/b9f4bf87e5d99063fb268b8fa0c729ff1fb29eb4)) | ||
|
|
There was a problem hiding this comment.
This section contains redundant entries for previous release commits (1.6.0 through 2.1.0) which clutter the changelog for version 3.0.0. These should be removed to keep the release notes focused on changes since version 2.1.0.
| * **main:** [bot] release common:2.0.0 ([#1972](https://github.com/teutonet/teutonet-helm-charts/issues/1972)) ([f49144b](https://github.com/teutonet/teutonet-helm-charts/commit/f49144b7bcdbd58554993b47fa711ec52b05a52e)) | ||
| * **main:** [bot] release common:2.1.0 ([#2068](https://github.com/teutonet/teutonet-helm-charts/issues/2068)) ([b9f4bf8](https://github.com/teutonet/teutonet-helm-charts/commit/b9f4bf87e5d99063fb268b8fa0c729ff1fb29eb4)) | ||
|
|
||
| ## [2.1.0](https://github.com/teutonet/teutonet-helm-charts/compare/common-v2.0.0...common-v2.1.0) (2026-04-30) |
There was a problem hiding this comment.
The release date for version 2.1.0 is incorrectly listed as 2026-04-30, which is the same as the current 3.0.0 release. This should be corrected to reflect the actual historical release date of version 2.1.0.
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 57 minutes and 29 seconds.Comment |
1 participant
🤖 I have created a release beep boop
3.0.0 (2026-04-30)
⚠ BREAKING CHANGES
Features
Miscellaneous Chores
This PR was generated with Release Please. See documentation.