Skip to content

feat(base-cluster): migrate loki to grafana-community helm chart#2118

Open
cwrau wants to merge 1 commit intomainfrom
origin/feat/base-cluster/migrate-loki-to-community-chart
Open

feat(base-cluster): migrate loki to grafana-community helm chart#2118
cwrau wants to merge 1 commit intomainfrom
origin/feat/base-cluster/migrate-loki-to-community-chart

Conversation

@cwrau
Copy link
Copy Markdown
Member

@cwrau cwrau commented Apr 27, 2026

Summary by CodeRabbit

  • Chores
    • Upgraded Loki monitoring and logging system to a newer version with performance improvements
    • Updated Helm chart source to leverage an improved distribution channel
    • Refined deployment configuration conditions for better integration with the monitoring infrastructure

Copilot AI review requested due to automatic review settings April 27, 2026 08:41
@cwrau cwrau enabled auto-merge April 27, 2026 08:41
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

📝 Walkthrough

Walkthrough

The Loki Helm chart dependency is migrated from the grafana repository to the grafana-community repository with version 13.2.3. The chart configuration adjusts the image registry key from global.registry to global.imageRegistry and changes the deployment mode from SingleBinary to Monolithic. The repository inclusion condition is updated to depend on monitoring.prometheus.enabled.

Changes

Cohort / File(s) Summary
Loki Chart Configuration
charts/base-cluster/templates/monitoring/logs/loki.yaml
Updates Helm chart repository source from grafana to grafana-community, adjusts global.registry to global.imageRegistry, and changes deploymentMode from SingleBinary to Monolithic.
Helm Chart Values
charts/base-cluster/values.yaml
Moves Loki chart version from 6.55.0 (grafana repo) to 13.2.3 (grafana-community repo); updates repository inclusion condition to depend on monitoring.prometheus.enabled and enables when tracing or Loki is enabled.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • #1955: Performs the same Helm repository migration for base-cluster monitoring (grafana to grafana-community) and updates related values/conditions.
  • #1605: Similar Grafana-related chart configuration updates for Tempo, adjusting image registry key names and repository references.

Suggested labels

base-cluster

Suggested reviewers

  • tasches
  • marvinWolff

Poem

🐰 Hop, hop! A migration spree, Loki charts are now set free!
From grafana to the community band, with monolithic mode, we've taken a stand.
Image registry keys aligned with care, version thirteen point two point three in the air! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: migrating Loki to the grafana-community Helm chart, which is the primary objective of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch origin/feat/base-cluster/migrate-loki-to-community-chart

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the Loki helm chart from the Grafana repository to the Grafana Community repository, updating the version to 13.2.3 and adjusting configuration values like deploymentMode and imageRegistry. Feedback indicates that the deploymentMode value should be lowercase 'monolithic' to ensure compatibility with the new chart's requirements.

Comment thread charts/base-cluster/templates/monitoring/logs/loki.yaml
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates the Loki HelmRelease in base-cluster from the grafana Helm repository to the grafana-community Helm repository, aligning chart sourcing and repository creation conditions with when Loki is enabled.

Changes:

  • Move Loki chart version pinning from global.helmRepositories.grafana to global.helmRepositories.grafana-community.
  • Update the Loki HelmRelease to reference the grafana-community repository and adjust chart values for the new chart.
  • Broaden the grafana-community HelmRepository creation condition to cover Loki-enabled clusters (not only tracing-enabled ones).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
charts/base-cluster/values.yaml Moves Loki chart pin to grafana-community and updates repo creation condition to include Loki.
charts/base-cluster/templates/monitoring/logs/loki.yaml Points Loki HelmRelease at grafana-community/loki and updates chart values for the migrated chart.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@charts/base-cluster/values.yaml`:
- Around line 128-133: Update the PR description / chart CHANGELOG to call out
the large cross-major-version bump for the grafana-community:loki chart (from
6.55.0 → 13.2.3 as referenced under the grafana-community.charts.loki entry),
explicitly note the Kubernetes 1.25+ and Helm 3.x requirements, mention the
default deploymentMode change (now Monolithic) and confirm we explicitly set
deploymentMode in our loki values, and advise operators to back up existing Loki
PVCs before upgrading; include these points succinctly in the PR/changelog so
downstream consumers of the loki chart and maintainers reviewing the
grafana-community block and its condition are aware.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a3150d67-3a85-49df-b823-1f6beffbf101

📥 Commits

Reviewing files that changed from the base of the PR and between 5de17f0 and 5a53fec.

📒 Files selected for processing (2)
  • charts/base-cluster/templates/monitoring/logs/loki.yaml
  • charts/base-cluster/values.yaml

Comment thread charts/base-cluster/values.yaml
@marvinWolff
Copy link
Copy Markdown
Collaborator

Is tested that the volume remains?

Just asking because it's not marked breaking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants