feat(t8s-cluster): add storage quota field

[cwrau]

Summary by CodeRabbit

• New Features
  • Added storage quota configuration support to enable fine-grained cluster resource management.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request extends the quotas schema in the t8s-cluster Helm chart configuration by adding a new storage quota field as an integer with a minimum constraint of -1, complementing the existing floatingIPs quota field.

Changes

Cohort / File(s)	Summary
Schema Extension charts/t8s-cluster/values.schema.json	Added storage quota field (integer type with minimum: -1 constraint) to the quotas schema definition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• feat(t8s-cluster/management-cluster): add quotas fied to cluster #1998: Modifies the same quotas schema in charts/t8s-cluster/values.schema.json (previously added floatingIPs field).

Suggested labels

t8s-cluster

Suggested reviewers

• marvinWolff
• teutonet-bot
• tasches

Poem

🐰 A storage quota hops into the schema so fine,
Integer constrained, minimum minus one in line,
Quotas grow fuller with each new field we add,
The cluster config dances, and we're quite glad! 📊

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding a storage quota field to the t8s-cluster chart schema.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/t8s-cluster/add-storage-quota

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request adds a storage quota field to the t8s-cluster Helm chart schema. A review comment suggests adding a description to this new field to clarify its purpose and units (e.g., GiB), as the current integer type is ambiguous regarding whether it represents a count or capacity.

[Copilot]

Pull request overview

Adds a new quotas.storage value to the t8s-cluster Helm chart JSON schema so that Helm values validation accepts a storage quota alongside existing quota fields.

Changes:

• Extend charts/t8s-cluster/values.schema.json to allow quotas.storage as an integer with a minimum of -1 (consistent with floatingIPs).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

🧹 Nitpick comments (1)

charts/t8s-cluster/values.schema.json (1)

173-176: LGTM! The new storage quota field is correctly implemented.

The schema definition follows the same pattern as the existing floatingIPs field, and the template at charts/t8s-cluster/templates/management-cluster/cluster.yaml will automatically render this new field via toYaml.

Optional enhancement: Add descriptions for clarity.

Consider adding a description field to both storage and floatingIPs to clarify their purpose and units. For example:

📝 Optional: Add descriptions to quota fields

     "quotas": {
       "type": "object",
       "properties": {
         "floatingIPs": {
           "type": "integer",
+          "description": "Maximum number of floating IPs that can be allocated. Use -1 for unlimited.",
           "minimum": -1
         },
         "storage": {
           "type": "integer",
+          "description": "Maximum storage quota in gigabytes. Use -1 for unlimited.",
           "minimum": -1
         }
       },

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@charts/t8s-cluster/values.schema.json` around lines 173 - 176, Add
descriptive metadata to the quota fields by adding a "description" entry for
both the "storage" and "floatingIPs" properties in values.schema.json; update
the "storage" property to include a clear description (e.g., units and semantics
such as "Storage quota in GiB, -1 for unlimited") and add a similar description
for "floatingIPs" (e.g., "Number of floating IPs allowed, -1 for unlimited") so
templates that render values via toYaml (e.g., cluster YAML) have clear
documentation for users.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@charts/t8s-cluster/values.schema.json`:
- Around line 173-176: Add descriptive metadata to the quota fields by adding a
"description" entry for both the "storage" and "floatingIPs" properties in
values.schema.json; update the "storage" property to include a clear description
(e.g., units and semantics such as "Storage quota in GiB, -1 for unlimited") and
add a similar description for "floatingIPs" (e.g., "Number of floating IPs
allowed, -1 for unlimited") so templates that render values via toYaml (e.g.,
cluster YAML) have clear documentation for users.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 00d06b3b-9341-47af-ad4d-fb5bf98473ce

📥 Commits

Reviewing files that changed from the base of the PR and between 04f3110 and 15dc64a.

📒 Files selected for processing (1)

• charts/t8s-cluster/values.schema.json