feat(t8s-cluster/management-cluster): set apiServerLoadBalancer.provider via TeutonetesCloud

[cwrau]

Summary by CodeRabbit

• New Features
  • Load balancer provider field now automatically populates based on cloud configuration when available for OpenStack clusters.
  • Maintains full backward compatibility with existing API server load balancer settings.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A Helm template file for the t8s-cluster chart now includes a new conditional logic to populate the loadBalancerProvider field under apiServerLoadBalancer by looking up the TeutonetesCloud resource and extracting provider information when available.

Changes

Cohort / File(s)	Summary
t8s-cluster Helm Template charts/t8s-cluster/templates/management-cluster/clusterClass/openStackClusterTemplate/_openStackClusterTemplateSpec.yaml	Added 4 lines to introduce a cloud template lookup and conditionally set the loadBalancerProvider field from the cloud spec. Existing apiServerLoadBalancer configuration and other sections remain unmodified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

t8s-cluster

Suggested reviewers

• tasches
• teutonet-bot
• marvinWolff

Poem

🐰 A cloud takes shape in template's care,
Provider fields float through the air,
Load balancers find their way,
Four lines of YAML brighten the day! ☁️

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: setting apiServerLoadBalancer.provider field using TeutonetesCloud lookup in the management cluster template.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3fced54 and 2e6ee92.

📒 Files selected for processing (1)

• charts/t8s-cluster/templates/management-cluster/clusterClass/openStackClusterTemplate/_openStackClusterTemplateSpec.yaml

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1601
File: charts/base-cluster/templates/dns/external-dns.yaml:30-32
Timestamp: 2025-07-24T09:55:53.655Z
Learning: In charts/base-cluster/templates/dns/external-dns.yaml, the dns.provider field in values.yaml has always been expected to be a map format (e.g., `{ cloudflare: {} }`), never a string format. The template correctly uses `{{ .Values.dns.provider | keys | first }}` to extract the provider name from the map keys.

Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1601
File: charts/base-cluster/templates/dns/external-dns.yaml:33-39
Timestamp: 2025-07-24T09:56:41.380Z
Learning: In the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for Cloudflare provider are intentionally hard-coded. Users who need custom secret names should use Helm's `valuesFrom` feature to override values rather than expecting dedicated fields in values.yaml. This design keeps the values.yaml clean while still allowing full customization flexibility.

📚 Learning: 2025-07-24T09:55:53.655Z

Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1601
File: charts/base-cluster/templates/dns/external-dns.yaml:30-32
Timestamp: 2025-07-24T09:55:53.655Z
Learning: In charts/base-cluster/templates/dns/external-dns.yaml, the dns.provider field in values.yaml has always been expected to be a map format (e.g., `{ cloudflare: {} }`), never a string format. The template correctly uses `{{ .Values.dns.provider | keys | first }}` to extract the provider name from the map keys.

Applied to files:

• charts/t8s-cluster/templates/management-cluster/clusterClass/openStackClusterTemplate/_openStackClusterTemplateSpec.yaml

📚 Learning: 2025-07-24T09:56:41.380Z

Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1601
File: charts/base-cluster/templates/dns/external-dns.yaml:33-39
Timestamp: 2025-07-24T09:56:41.380Z
Learning: In the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for Cloudflare provider are intentionally hard-coded. Users who need custom secret names should use Helm's `valuesFrom` feature to override values rather than expecting dedicated fields in values.yaml. This design keeps the values.yaml clean while still allowing full customization flexibility.

Applied to files:

• charts/t8s-cluster/templates/management-cluster/clusterClass/openStackClusterTemplate/_openStackClusterTemplateSpec.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Agent
• GitHub Check: wait-for-checks

🔇 Additional comments (1)

charts/t8s-cluster/templates/management-cluster/clusterClass/openStackClusterTemplate/_openStackClusterTemplateSpec.yaml (1)

13-15: Safe navigation pattern is correct.

The with block combined with the parenthesized safe navigation (($cloud).spec).loadBalancerProvider correctly handles cases where:

• The TeutonetesCloud resource doesn't exist ($cloud is empty map)
• The resource exists but lacks spec or loadBalancerProvider

In all these cases, the provider field is omitted as intended.

Note: The TeutonetesCloud CRD is external (t8s-engine.teuto.net/v1alpha1) and not defined in this repository, so the spec.loadBalancerProvider field path cannot be verified from the codebase alone. Verification of the field path requires access to the external CRD schema.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @cwrau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature to dynamically configure the API server load balancer provider within the t8s-cluster management cluster for OpenStack. By integrating with the TeutonetesCloud custom resource, the system can now automatically apply the specified load balancer provider, enhancing the declarative management of cloud infrastructure settings and improving overall configuration flexibility.

Highlights

• Dynamic Load Balancer Provider Configuration: The apiServerLoadBalancer.provider field can now be dynamically set for OpenStack clusters, allowing for more flexible and centralized management of load balancer types.
• Integration with TeutonetesCloud: The configuration now leverages the TeutonetesCloud custom resource to retrieve the loadBalancerProvider setting, ensuring consistency with cloud-specific definitions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to set the apiServerLoadBalancer.provider using a value from a TeutonetesCloud resource. The current implementation, however, does not safely handle the case where the lookup for this resource might fail to find it. This could lead to template rendering errors. My review includes a critical comment with a suggested code change to add the necessary checks and prevent such errors.

[Copilot]

Pull request overview

This PR adds the ability to dynamically set the apiServerLoadBalancer.provider field in OpenStack cluster templates by looking up the value from a TeutonetesCloud custom resource. The implementation uses Helm's lookup function to fetch the TeutonetesCloud resource and extract the loadBalancerProvider field from its spec.

Changes:

• Adds a lookup to fetch TeutonetesCloud resource based on the cloud value
• Conditionally sets apiServerLoadBalancer.provider if the loadBalancerProvider field exists in the TeutonetesCloud spec
• Uses the with statement to handle cases where the field may not be present

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.