fix(base-cluster/monitoring): move imageRenderer config to correct place

[cwrau]

Summary by CodeRabbit

• Chores
  • Reorganized monitoring configuration by relocating the image renderer settings within the Grafana template.
  • Adjusted how the renderer image registry is resolved by changing the default resolution method — may affect which image registry is used when no explicit registry is provided.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Relocated the imageRenderer configuration block within the Grafana template from an earlier position to under defaultDashboardsEnabled and changed its image registry default to use .registry directly; nested fields (repository, tag, automountServiceAccountToken, securityContext) were preserved.

Changes

Cohort / File(s)	Summary
Grafana configuration template charts/base-cluster/templates/monitoring/kube-prometheus-stack/_grafana-config.yaml	Moved the imageRenderer block from the top of the template to a later section (under defaultDashboardsEnabled) and adjusted the block's registry default to use .registry directly; preserved nested fields (repository, tag, automountServiceAccountToken, securityContext).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Single-file change with a small configuration relocation and a registry-default tweak.
• Check YAML indentation and structure after move.
• Verify the registry default behavior in template rendering (ensure no unintended nil/empty resolution).

Possibly related PRs

• fix(base-cluster/monitoring): pin image-renderer version to ensure it's compatible #1631 — Modifies Grafana imageRenderer rendering and registry resolution; closely related to the same template area.

Suggested reviewers

• tasches
• teutonet-bot

Poem

🐰 I hopped a config block down the hill,
Same tags, same repo, same gentle will.
A tiny registry tweak, neat and spry,
Now Grafana paints with a clearer sky. 🎨🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the main change: moving imageRenderer configuration to the correct location in the Grafana configuration template.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/base-cluster/grafana-image-renderer-config

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9558435 and 8dcacfe.

📒 Files selected for processing (1)

• charts/base-cluster/templates/monitoring/kube-prometheus-stack/_grafana-config.yaml (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-07-24T09:55:53.655Z

Learnt from: cwrau
Repo: teutonet/teutonet-helm-charts PR: 1601
File: charts/base-cluster/templates/dns/external-dns.yaml:30-32
Timestamp: 2025-07-24T09:55:53.655Z
Learning: In charts/base-cluster/templates/dns/external-dns.yaml, the dns.provider field in values.yaml has always been expected to be a map format (e.g., `{ cloudflare: {} }`), never a string format. The template correctly uses `{{ .Values.dns.provider | keys | first }}` to extract the provider name from the map keys.

Applied to files:

• charts/base-cluster/templates/monitoring/kube-prometheus-stack/_grafana-config.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: check licenses
• GitHub Check: lint helm chart (base-cluster)

🔇 Additional comments (1)

charts/base-cluster/templates/monitoring/kube-prometheus-stack/_grafana-config.yaml (1)

63-77: ✓ Registry syntax fix approved.

The previous issue with invalid printf syntax has been correctly resolved. Line 67 now properly uses {{ $.Values.global.imageRegistry | default .registry }} instead of printf .registry.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @cwrau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a structural issue within the Grafana Helm chart template by relocating the imageRenderer configuration. The change ensures that the image renderer settings are correctly parsed and applied, which is crucial for the proper functioning of Grafana's image rendering capabilities.

Highlights

• Configuration Relocation: The imageRenderer configuration block for Grafana has been moved to its correct hierarchical position within the _grafana-config.yaml template.
• Helm Chart Structure Correction: This change corrects the YAML structure within the Helm chart template, ensuring the imageRenderer settings are applied as intended.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully moves the imageRenderer configuration block within the _grafana-config.yaml file to its intended location. This refactoring improves the organization and maintainability of the Grafana Helm chart configuration without altering its functionality. The change aligns the configuration with best practices for Helm chart structure, making it easier to understand and manage.

[Copilot]

Pull request overview

This PR fixes the placement of the imageRenderer configuration block in the Grafana subchart configuration for kube-prometheus-stack. The imageRenderer configuration was incorrectly positioned at the beginning of the template definition and has been moved to its proper location after defaultDashboardsEnabled, ensuring it's placed at the correct level within the Grafana configuration hierarchy.

Key Changes

• Moved imageRenderer configuration block from the top of the template to after defaultDashboardsEnabled
• Configuration includes image settings, security context, and service account token settings for the Grafana image renderer

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82b78e5 and 9558435.

📒 Files selected for processing (1)

• charts/base-cluster/templates/monitoring/kube-prometheus-stack/_grafana-config.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: check licenses
• GitHub Check: Agent
• GitHub Check: lint helm chart (base-cluster)