chore(base-cluster/dependencies)!: update helm release velero to v11 - abandoned by renovate[bot] · Pull Request #1827 · teutonet/teutonet-helm-charts

Documentation
- Added migration guidance for Velero backup uploader backend transition
New Features
- Velero now uses kopia as the backup uploader
- Added validation to block installation/upgrades if restic repositories are present
Chores
- Updated Velero Helm chart to version 11.3.2

coderabbitai · 2025-11-27T15:43:57Z

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The pull request title accurately and specifically describes the main change: upgrading the Velero Helm release from v7 to v11, which is the primary objective of the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch renovate/base-cluster-velero-11.x

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

renovate · 2026-01-22T16:56:10Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

renovate · 2026-03-16T05:57:20Z

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@charts/base-cluster/README.md.gotmpl`:
- Around line 438-440: The README currently references the wrong values key
`backup.velero.defaultLocation`; update the documentation text to point to the
actual chart values key `.backup.provider.velero.defaultLocation` (and any
similar occurrences) so users set the correct path when creating a new bucket
and configuring Velero; search for `backup.velero.defaultLocation` in the README
and replace it with `.backup.provider.velero.defaultLocation` and verify
examples and backticks use the exact dotted path.

In `@charts/base-cluster/templates/backup/velero/velero.yaml`:
- Around line 2-6: The template unconditionally accesses (lookup ...).items
which fails when lookup returns an empty map; guard that access by first
capturing the lookup result and checking it has items before ranging. For
example, assign the lookup to a variable (e.g., $repos := lookup "velero.io/v1"
"BackupRepository" "backup" "") and then wrap the range in a guard like {{- with
$repos.items }} ... {{- end }} (or check that $repos and $repos.items are
non-empty) before iterating and inspecting repo.spec.repositoryType and calling
fail/printf with repo.metadata.name.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5d632ce1-6aed-4dca-9b27-7fe60568caa7

📥 Commits

Reviewing files that changed from the base of the PR and between 39e7f6a and 2d30d63.

📒 Files selected for processing (4)

charts/base-cluster/README.md.gotmpl
charts/base-cluster/templates/backup/velero/velero.yaml
charts/base-cluster/templates/kyverno/policies/kyverno-base-policies/kyverno-policies.yaml
charts/base-cluster/values.yaml

coderabbitai · 2026-04-29T12:12:32Z

+{{- range $index, $repo := (lookup "velero.io/v1" "BackupRepository" "backup" "").items}}
+  {{- if eq $repo.spec.repositoryType "restic" }}
+    {{- fail (printf "The Backuprepository '%s' is of unsupported type restic" $repo.metadata.name) }}
+  {{- end }}
+{{- end }}


⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# First, let's examine the actual file to see the code at lines 2-6 cat -n charts/base-cluster/templates/backup/velero/velero.yaml | head -20

Repository: teutonet/teutonet-helm-charts

Length of output: 963

🏁 Script executed:

# Also check if there's context around this - let's see a wider range wc -l charts/base-cluster/templates/backup/velero/velero.yaml

Repository: teutonet/teutonet-helm-charts

Length of output: 133

🏁 Script executed:

# Search for similar lookup() patterns in the repository to see how they're handled rg "lookup\s*\(" charts/ -A 2 -B 1 | head -100

Repository: teutonet/teutonet-helm-charts

Length of output: 55

🌐 Web query:

Helm template lookup function null empty handling .items

💡 Result:

In Helm templates, the lookup function returns an empty map/dict {} when no matching resources are found in the cluster (or during helm template/--dry-run without cluster access). This empty map does not have an .items field. Accessing .items on an empty lookup result causes a "nil pointer" or similar template error because .items is nil/undefined. To safely handle this: 1. Check if lookup returned a non-empty result before accessing .items: {{- $lookupResult := lookup "v1" "Service" "mynamespace" "" }} {{- if $lookupResult }} {{- range $service := $lookupResult.items }} # process $service {{- end }} {{- end }} 2. For list lookups (empty name ""), check length: {{- if eq (len (lookup "v1" "Service" "mynamespace" "")) 0 }} # No services found {{- else }} # Services exist {{- end }} The official Helm docs confirm: "When lookup returns a list of objects, it is possible to access the object list via the items field" but "When no object is found, an empty value is returned." The Go template source code explicitly returns map[string]interface{}{} (empty map) on not found, enabling if not (lookup ...) checks. Always wrap .items access in if $lookupResult to avoid errors.

Citations:

1: https://helm.sh/docs/chart_template_guide/functions_and_pipelines

2: https://github.com/helm/helm/blob/340b06d8/pkg/engine/lookup_func.go

3: https://stackoverflow.com/questions/71156026/helm-lookup-always-empty

4: https://oneuptime.com/blog/post/2026-01-17-helm-lookup-function-dynamic-discovery/view

🏁 Script executed:

# Check if there's any error handling or similar patterns in the templates rg "if.*lookup\|if.*\$" charts/base-cluster/templates/ -A 2 -B 1 | head -50

Repository: teutonet/teutonet-helm-charts

Length of output: 55

🏁 Script executed:

# Look for any Helm documentation or comments about lookup in the codebase rg -i "lookup.*backuprepository\|backuprepository.*lookup" charts/

Repository: teutonet/teutonet-helm-charts

Length of output: 55

🏁 Script executed:

# Check the git history to understand when this was added and why git log --oneline -n 20 -- charts/base-cluster/templates/backup/velero/velero.yaml

Repository: teutonet/teutonet-helm-charts

Length of output: 150

🏁 Script executed:

# Let's check the full context of how this template is used - are BackupRepositories always present? cat -n charts/base-cluster/templates/backup/velero/velero.yaml | sed -n '1,30p'

Repository: teutonet/teutonet-helm-charts

Length of output: 1212

🏁 Script executed:

# Check if there's any documentation or values file that explains the expected state find charts/base-cluster -name "*.md" -o -name "*values*" | xargs rg -l "BackupRepository\|velero" 2>/dev/null

Repository: teutonet/teutonet-helm-charts

Length of output: 57

🏁 Script executed:

# Check the values defaults fd "values" charts/base-cluster/ --type f | head -5

Repository: teutonet/teutonet-helm-charts

Length of output: 307

🏁 Script executed:

# Check if there's documentation about the velero setup and expected state cat -n charts/base-cluster/templates/backup/velero/README.md 2>/dev/null || echo "No README found"

Repository: teutonet/teutonet-helm-charts

Length of output: 89

🏁 Script executed:

# Look at the chart's values.yaml to understand defaults cat charts/base-cluster/values.yaml | grep -A 20 "backup:" | head -30

Repository: teutonet/teutonet-helm-charts

Length of output: 881

🏁 Script executed:

# Verify if this pattern is consistently an issue - check when lookup is used without guarding rg "lookup.*\(" charts/ -A 1 | grep -E "lookup|\.items" | head -20

Repository: teutonet/teutonet-helm-charts

Length of output: 851

Guard the lookup result before accessing .items.

The lookup() function returns an empty map when the BackupRepository resource is not found (e.g., during initial deployment or when running helm template/dry-run without cluster access). Accessing .items on this empty result causes template rendering to fail. The condition wrapping this block checks only if Velero is enabled, not whether BackupRepository resources exist.

🔧 Proposed fix

{{- if (.Values.backup.provider).velero }} -{{- range $index, $repo := (lookup "velero.io/v1" "BackupRepository" "backup" "").items}} - {{- if eq $repo.spec.repositoryType "restic" }} - {{- fail (printf "The Backuprepository '%s' is of unsupported type restic" $repo.metadata.name) }} - {{- end }} -{{- end }} +{{- $repos := lookup "velero.io/v1" "BackupRepository" "backup" "" -}} +{{- if $repos }} +{{- range $repo := $repos.items }} + {{- if eq $repo.spec.repositoryType "restic" }} + {{- fail (printf "The BackupRepository '%s' is of unsupported type restic" $repo.metadata.name) }} + {{- end }} +{{- end }} +{{- end }} apiVersion: helm.toolkit.fluxcd.io/v2

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@charts/base-cluster/templates/backup/velero/velero.yaml` around lines 2 - 6, The template unconditionally accesses (lookup ...).items which fails when lookup returns an empty map; guard that access by first capturing the lookup result and checking it has items before ranging. For example, assign the lookup to a variable (e.g., $repos := lookup "velero.io/v1" "BackupRepository" "backup" "") and then wrap the range in a guard like {{- with $repos.items }} ... {{- end }} (or check that $repos and $repos.items are non-empty) before iterating and inspecting repo.spec.repositoryType and calling fail/printf with repo.metadata.name.

cwrau · 2026-04-29T13:14:54Z

@@ -1,4 +1,9 @@
 {{- if (.Values.backup.provider).velero }}
+{{- range $index, $repo := (lookup "velero.io/v1" "BackupRepository" "backup" "").items}}


You don't need the index

cwrau · 2026-04-29T13:15:30Z

 {{- if (.Values.backup.provider).velero }}
+{{- range $index, $repo := (lookup "velero.io/v1" "BackupRepository" "backup" "").items}}
+  {{- if eq $repo.spec.repositoryType "restic" }}
+    {{- fail (printf "The Backuprepository '%s' is of unsupported type restic" $repo.metadata.name) }}


Aren't they namespaced? If yes you should also print out the namespace

cwrau · 2026-04-29T13:15:54Z

      seccompProfile:
        type: RuntimeDefault
+    extraVolumeMounts:
+      - mountPath: /udmrepo


cwrau · 2026-04-29T13:17:42Z

      url: https://vmware-tanzu.github.io/helm-charts
      charts:
-        velero: 7.2.2
+        velero: 11.3.2


Wasn't there 12 already released?

renovate Bot added the dependencies label Nov 27, 2025

renovate Bot requested review from cwrau, marvinWolff, tasches and teutonet-bot as code owners November 27, 2025 15:43

renovate Bot enabled auto-merge November 27, 2025 15:43

github-actions Bot assigned renovate[bot] Nov 27, 2025

teutonet-bot added the base-cluster label Nov 27, 2025

renovate Bot force-pushed the renovate/base-cluster-velero-11.x branch 19 times, most recently from 0a20990 to e653c75 Compare December 4, 2025 11:14

renovate Bot force-pushed the renovate/base-cluster-velero-11.x branch 2 times, most recently from a4909ea to 5a9bdc9 Compare December 5, 2025 10:09

renovate Bot force-pushed the renovate/base-cluster-velero-11.x branch from 56d64b1 to 99347d4 Compare December 29, 2025 13:02

renovate Bot force-pushed the renovate/base-cluster-velero-11.x branch 9 times, most recently from ca8d962 to 2a41bd7 Compare January 9, 2026 14:40

renovate Bot force-pushed the renovate/base-cluster-velero-11.x branch 13 times, most recently from 043d6b9 to 354f307 Compare January 21, 2026 11:07

renovate Bot and others added 2 commits April 29, 2026 13:49

chore(base-cluster/dependencies)!: update helm release velero to v11

5bee063

chore(base-cluster/velero)!: update velero, checks and documentation

2d30d63

coderabbitai Bot reviewed Apr 29, 2026

View reviewed changes

fix(docs): change path description to correct value

0ca4cb9

cwrau requested changes Apr 29, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(base-cluster/dependencies)!: update helm release velero to v11 - abandoned#1827

chore(base-cluster/dependencies)!: update helm release velero to v11 - abandoned#1827
renovate[bot] wants to merge 3 commits intomainfrom
renovate/base-cluster-velero-11.x

renovate Bot commented Nov 27, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Nov 27, 2025 •

edited

Loading

Uh oh!

renovate Bot commented Jan 22, 2026

Uh oh!

renovate Bot commented Mar 16, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot Apr 29, 2026

Uh oh!

cwrau Apr 29, 2026

Uh oh!

cwrau Apr 29, 2026

Uh oh!

cwrau Apr 29, 2026

Uh oh!

cwrau Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -1,4 +1,9 @@
		{{- if (.Values.backup.provider).velero }}
		{{- range $index, $repo := (lookup "velero.io/v1" "BackupRepository" "backup" "").items}}

Conversation

renovate Bot commented Nov 27, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Notes

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

What's Changed

What's Changed

New Contributors

What's Changed

What's Changed

New Contributors

What's Changed

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

What's Changed

What's Changed

What's Changed

What's Changed

What's Changed

New Contributors

What's Changed

What's Changed

New Contributors

What's Changed

What's Changed

New Contributors

What's Changed

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

What's Changed

Configuration

Summary by CodeRabbit

Release Notes

Uh oh!

renovate Bot commented Nov 27, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Nov 27, 2025 •

edited

Loading