fix(t8s-cluster/management-cluster): fix replicas type checking

[cwrau]

Summary by CodeRabbit

• Bug Fixes
  • Improved validation logic for cluster node pool replica count configurations to ensure accurate min/max validation checks.

[Copilot]

Pull Request Overview

This PR fixes the type checking logic for replica configuration in the management cluster template by replacing typeIs with the more appropriate kindIs function.

Key Changes:

• Changed type checking function from typeIs to kindIs for replica validation in the cluster template

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This PR modifies the Helm template introspection method in the cluster configuration from typeIs to kindIs when evaluating the replicas field type. This affects the conditional logic that determines when minReplicas/maxReplicas validation is triggered for nodePools entries.

Changes

Cohort / File(s)	Summary
Template introspection update charts/t8s-cluster/templates/management-cluster/cluster.yaml	Changed replicas field type check from typeIs "map" to kindIs "map", modifying the control flow for minReplicas/maxReplicas validation in nodePools

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• feat(t8s-cluster): implement autoscaling #1686: Introduces minReplicas/maxReplicas validation for nodePools that this PR refines by switching from typeIs to kindIs introspection method.

Suggested reviewers

• marvinWolff
• tasches
• teutonet-bot

Poem

🐰 A tiny tweak, but oh so fine,
From typeIs to kindIs we align,
The validation now flows just right,
Replicas dance in Helm's twilight! ✨

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/t8s-cluster/correct-map-checking

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a5bb05 and 12749b1.

📒 Files selected for processing (1)

• charts/t8s-cluster/templates/management-cluster/cluster.yaml (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}