chore(main): [bot] release base-cluster:9.3.1#1659
Conversation
teutonet-bot
requested review from
a team,
cwrau,
marvinWolff and
tasches
as code owners
WalkthroughPatch release metadata for the base-cluster chart: Chart.yaml version bumped to 9.3.1, CHANGELOG.md updated with a 9.3.1 entry, and .github release manifest updated. No chart templates or runtime logic changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Out-of-scope changes
Possibly related PRs
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
charts/base-cluster/Chart.yaml (1)
19-19: Update versioned source link to match 9.3.1.The first sources URL still points to
base-cluster-v9.3.0. This can confuse consumers (e.g., on Artifact Hub). Recommend bumping tov9.3.1.Apply this diff:
- - https://github.com/teutonet/teutonet-helm-charts/tree/base-cluster-v9.3.0/charts/base-cluster + - https://github.com/teutonet/teutonet-helm-charts/tree/base-cluster-v9.3.1/charts/base-cluster
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
.github/release-please/manifest.json(1 hunks)charts/base-cluster/CHANGELOG.md(1 hunks)charts/base-cluster/Chart.yaml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-24T09:41:28.072Z
Learnt from: cwrau
PR: teutonet/teutonet-helm-charts#1604
File: charts/base-cluster/templates/monitoring/metrics-server/metrics-server.yaml:20-21
Timestamp: 2025-07-24T09:41:28.072Z
Learning: The official kubernetes-sigs/metrics-server Helm chart pins the image tag to a specific version in its values.yaml by default, ensuring reproducible deployments without requiring explicit tag specification in consuming charts.
Applied to files:
charts/base-cluster/Chart.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: check licenses
- GitHub Check: update metadata file for release
- GitHub Check: lint helm chart (base-cluster)
🔇 Additional comments (4)
.github/release-please/manifest.json (2)
1-1: Manifest bump aligns with Chart.yaml 9.3.1.Base-cluster is correctly bumped to 9.3.1; other chart versions remain unchanged as expected.
1-1: Fix required: templates still use truthiness for .Values.dns.provider — switch to hasKey presence checksSearch of charts/base-cluster/templates shows multiple conditional checks still using .Values.dns.provider (truthiness). That will treat an empty/falsy value as "disabled" — we should test for the presence of the key instead (hasKey).
Offending locations (examples):
- charts/base-cluster/templates/dns/external-dns.yaml
- line 1: {{- if .Values.dns.provider -}}
- uses: {{ .Values.dns.provider | keys | first }} and {{- if .Values.dns.provider.cloudflare }}
- charts/base-cluster/templates/cert-manager/clusterissuer.yaml
- {{- if .Values.dns.provider }} and {{- if .Values.dns.provider.cloudflare }}
- charts/base-cluster/templates/global/cluster-ingress.yaml
- {{- if and .Values.dns.provider .Values.global.baseDomain (ne .Values.ingress.provider "none") }}
- charts/base-cluster/templates/global/certificates.yaml
- {{- if not $.Values.dns.provider -}}
- charts/base-cluster/templates/monitoring/kube-prometheus-stack/*.yaml
- several occurrences (oauth-proxy.yaml, _helpers.yaml, _grafana-config.yaml)
Suggested fix (apply consistently and keep provider-specific lookups inside the presence guard):
Replace
{{- if .Values.dns.provider -}}
with
{{- if and (hasKey .Values "dns") (hasKey .Values.dns "provider") -}}For provider-specific branches, use hasKey on the provider map (inside the outer guard), e.g.
{{- if hasKey .Values.dns.provider "cloudflare" -}}
...
{{- end -}}Also ensure expressions like {{ .Values.dns.provider | keys | first }} are only evaluated inside the presence check.
⛔ Skipped due to learnings
Learnt from: cwrau PR: teutonet/teutonet-helm-charts#1601 File: charts/base-cluster/templates/dns/external-dns.yaml:30-32 Timestamp: 2025-07-24T09:55:53.655Z Learning: In charts/base-cluster/templates/dns/external-dns.yaml, the dns.provider field in values.yaml has always been expected to be a map format (e.g., `{ cloudflare: {} }`), never a string format. The template correctly uses `{{ .Values.dns.provider | keys | first }}` to extract the provider name from the map keys.Learnt from: cwrau PR: teutonet/teutonet-helm-charts#1601 File: charts/base-cluster/templates/dns/external-dns.yaml:33-39 Timestamp: 2025-07-24T09:56:41.380Z Learning: In the teutonet-helm-charts base-cluster chart, secret names like "external-dns" for Cloudflare provider are intentionally hard-coded. Users who need custom secret names should use Helm's `valuesFrom` feature to override values rather than expecting dedicated fields in values.yaml. This design keeps the values.yaml clean while still allowing full customization flexibility.charts/base-cluster/Chart.yaml (1)
22-22: LGTM: chart version bumped to 9.3.1.Version aligns with the manifest and changelog.
charts/base-cluster/CHANGELOG.md (1)
3-9: Changelog entry looks correct for 9.3.1.Version, date, and linked issue/commit are all present and consistent.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
charts/base-cluster/README.md (1)
249-250: Fix markdown list style (MD004): switch asterisks to dashes.Static analysis flags unordered list style; the rest of the doc predominantly uses dashes. Unify these two bullets:
-* https://github.com/teutonet/teutonet-helm-charts/tree/base-cluster-v9.3.1/charts/base-cluster -* https://github.com/teutonet/teutonet-helm-charts/tree/main/charts/base-cluster +- https://github.com/teutonet/teutonet-helm-charts/tree/base-cluster-v9.3.1/charts/base-cluster +- https://github.com/teutonet/teutonet-helm-charts/tree/main/charts/base-cluster
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
charts/base-cluster/Chart.yaml(2 hunks)charts/base-cluster/README.md(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- charts/base-cluster/Chart.yaml
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
charts/base-cluster/README.md
249-249: Unordered list style
Expected: dash; Actual: asterisk
(MD004, ul-style)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: lint helm chart (base-cluster)
🔇 Additional comments (1)
charts/base-cluster/README.md (1)
3-3: Version badge bump is correct and consistent with the release.9.3.1 badge looks good and aligns with the PR’s patch release.
teutonet-bot
deleted the
release-please--branches--main--components--base-cluster
branch
|
🤖 Created releases: 🌻 |
2 participants
🤖 I have created a release beep boop
9.3.1 (2025-08-15)
Bug Fixes
This PR was generated with Release Please. See documentation.
Summary by CodeRabbit
Bug Fixes
Chores
Documentation