Conversation
cwrau
requested review from
marvinWolff,
tasches and
teutonet-bot
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds tolerations to the Alloy log collector component to allow it to be scheduled on Kubernetes control-plane nodes, expanding its deployment scope beyond worker nodes.
- Adds NoSchedule toleration for control-plane nodes to the Alloy controller configuration
- Enables log collection from control-plane nodes that are typically tainted to prevent regular workload scheduling
WalkthroughA toleration was added to the controller specification in the telemetry-collector HelmRelease resource within the Alloy monitoring configuration. This toleration permits the pod to be scheduled on nodes tainted with Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
charts/base-cluster/templates/monitoring/alloy.yaml (1)
275-278: Toleration looks correct; consider covering pre-1.24 clusters as wellThe new toleration enables scheduling on nodes tainted with
node-role.kubernetes.io/control-plane, which is perfect for modern clusters.
If any environments are still on Kubernetes versions that use the oldernode-role.kubernetes.io/mastertaint, a second entry will ensure the DaemonSet lands on those control-plane nodes too:tolerations: - effect: NoSchedule key: node-role.kubernetes.io/control-plane operator: Exists + - effect: NoSchedule + key: node-role.kubernetes.io/master + operator: ExistsThis is optional, but it future-proofs the deployment against mixed or legacy clusters.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
charts/base-cluster/templates/monitoring/alloy.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: check licenses
- GitHub Check: lint helm chart (base-cluster)
- GitHub Check: wait-for-checks
cwrau
deleted the
chore/base-cluster/deploy-log-collector-to-control-plane
branch
🤖 I have created a release *beep* *boop* --- ## [9.0.0](base-cluster-v8.2.1...base-cluster-v9.0.0) (2025-07-25) ### ⚠ BREAKING CHANGES * **base-cluster/monitoring/alertmanager:** add receiver and route configuration capabilities ([#1600](#1600)) ### Features * **base-cluster/monitoring/alertmanager:** add receiver and route configuration capabilities ([#1600](#1600)) ([7f549fb](7f549fb)) * **base-cluster/monitoring:** don't automount the ServiceAccountToken ([#1615](#1615)) ([52386b7](52386b7)) ### Miscellaneous Chores * **base-cluster/monitoring:** deploy log collector to potential control-plane ([#1616](#1616)) ([e021845](e021845)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added configuration options for monitoring alertmanager receiver and route. * Enabled the ability to disable automounting of the ServiceAccountToken in the monitoring component. * **Breaking Changes** * Introduced breaking changes related to monitoring alertmanager configuration. * **Chores** * Deployed a log collector to potential control-plane nodes. * **Documentation** * Updated changelog to reflect new features and breaking changes in version 9.0.0. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Summary by CodeRabbit