ci(t8s-cluster/artifacthub-images): Update ArtifactHUB images#1497
ci(t8s-cluster/artifacthub-images): Update ArtifactHUB images#1497teutonet-bot merged 0 commit intomainfrom
Conversation
|
""" WalkthroughThe Helm chart metadata file for the t8s-cluster was updated to specify newer container image versions for OpenStack Cinder CSI driver components and the cloud controller manager. The CSI sidecar image versions were also increased, and their order in the list was adjusted. No other metadata or annotations were changed. Changes
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🤖 I have diffed this beep boop"/$namespace/$kind/$name.yaml" for normal resources
|
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
charts/t8s-cluster/Chart.yaml(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Check used licenses
charts/t8s-cluster/Chart.yaml
[error] 1-1: The following images have no license, please review: registry.k8s.io/sig-storage/csi-attacher, registry.k8s.io/sig-storage/csi-node-driver-registrar, registry.k8s.io/sig-storage/csi-provisioner, registry.k8s.io/sig-storage/csi-resizer, registry.k8s.io/sig-storage/csi-snapshotter, registry.k8s.io/sig-storage/livenessprobe.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: wait-for-checks
| - image: registry.k8s.io/provider-os/cinder-csi-plugin:v1.32.0 # default/HelmRelease/t8s-cluster-csi/kube-system/DaemonSet/openstack-cinder-csi-nodeplugin.yaml | ||
| - image: registry.k8s.io/provider-os/cinder-csi-plugin:v1.32.0 # default/HelmRelease/t8s-cluster-csi/kube-system/Deployment/openstack-cinder-csi-controllerplugin.yaml | ||
| - image: registry.k8s.io/provider-os/openstack-cloud-controller-manager:v1.32.0 # default/HelmRelease/t8s-cluster-ccm/kube-system/DaemonSet/openstack-cloud-controller-manager.yaml |
There was a problem hiding this comment.
Ensure chart version bump and image immutability.
You’ve updated the cinder-csi-plugin and CCM images without bumping the chart’s version (still 9.2.1). Any change in Chart.yaml requires a new patch version (e.g., 9.2.2). Additionally, these new tags lack @sha256:<digest>—please pin them with digests for immutability.
🤖 Prompt for AI Agents
In charts/t8s-cluster/Chart.yaml around lines 31 to 33, you updated container
image tags but did not bump the chart version; increment the patch version from
9.2.1 to 9.2.2 to reflect this change. Also, replace the image tags with fully
immutable references by appending the corresponding @sha256:<digest> for each
image to ensure image immutability.
| - image: registry.k8s.io/sig-storage/csi-attacher:v4.7.0 # default/HelmRelease/t8s-cluster-csi/kube-system/Deployment/openstack-cinder-csi-controllerplugin.yaml | ||
| - image: registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.12.0 # default/HelmRelease/t8s-cluster-csi/kube-system/DaemonSet/openstack-cinder-csi-nodeplugin.yaml | ||
| - image: registry.k8s.io/sig-storage/csi-provisioner:v5.1.0 # default/HelmRelease/t8s-cluster-csi/kube-system/Deployment/openstack-cinder-csi-controllerplugin.yaml | ||
| - image: registry.k8s.io/sig-storage/csi-resizer:v1.12.0 # default/HelmRelease/t8s-cluster-csi/kube-system/Deployment/openstack-cinder-csi-controllerplugin.yaml | ||
| - image: registry.k8s.io/sig-storage/csi-snapshotter:v8.1.0 # default/HelmRelease/t8s-cluster-csi/kube-system/Deployment/openstack-cinder-csi-controllerplugin.yaml | ||
| - image: registry.k8s.io/sig-storage/livenessprobe:v2.14.0 # default/HelmRelease/t8s-cluster-csi/kube-system/DaemonSet/openstack-cinder-csi-nodeplugin.yaml | ||
| - image: registry.k8s.io/sig-storage/livenessprobe:v2.14.0 # default/HelmRelease/t8s-cluster-csi/kube-system/Deployment/openstack-cinder-csi-controllerplugin.yaml |
There was a problem hiding this comment.
Add license metadata for new CSI sidecar images.
The GitHub Actions license check is failing because these sidecar images have no declared license. Please confirm each image’s license (e.g., Apache-2.0) and add an artifacthub.io/licenses annotation listing them.
🤖 Prompt for AI Agents
In charts/t8s-cluster/Chart.yaml around lines 34 to 40, the new CSI sidecar
images lack license metadata, causing the GitHub Actions license check to fail.
Confirm the license for each image, such as Apache-2.0, and add an
artifacthub.io/licenses annotation for each image entry to declare their
licenses properly.
f88c3c9 to
05305fd
Compare
Pull request was closed
05305fd to
f70df9a
Compare
Updates the ArtifactHUB images to the really deployed ones.
Summary by CodeRabbit